[ 
https://issues.apache.org/jira/browse/MAHOUT-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ikumasa Mukai updated MAHOUT-840:
---------------------------------

    Attachment: regression.patch

Hi.
I made a new patch!

> 1. (int) on a double means Math.floor(double). Would it make more sense to 
> round up or down?

I think we can (int) because most parts using cast(double->int) are for the 
index of the categorical attributes. To make them clear, I added comments on on 
every parts.

Would you please tell me your thought about this?

> 2. Leaf.hashCode() needs a matching equals().
>  ・The equals() should compare with an epsilon.
>  ・clamping to (int) is probably not a very good hash function

I fixed with the way you advised me!

> 3. Please add both a unit test and an example.

I added them!

Regards,
                
> Decision Forests should support Regression problems
> ---------------------------------------------------
>
>                 Key: MAHOUT-840
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-840
>             Project: Mahout
>          Issue Type: New Feature
>          Components: Classification
>            Reporter: Deneche A. Hakim
>            Assignee: Deneche A. Hakim
>         Attachments: regression.patch, regression.patch
>
>
> Improve Decision Forest code in order to handle numerical targets, thus 
> supporting regression problems

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to