Hi Dmitry, I've been using SVN to generate diffs for reviewboard which work fine.
The diffs coming out of Git seemed to have a different format which I had problems with, although I didn't spend a lot of time trying to get this working. On Dec 19, 2011, at 2:01 PM, Dmitriy Lyubimov <[email protected]> wrote: > Thanks, Patrick. > > it says it will accept any unified diff format. Does it mean it will > accept a standard 'diff' output? > > in theory, I can try to tune my local git to produce diffs with a > standard diff routine if it works. I > > am not sure what it has to do with repository type. Other folks in > our project seemed to have been able to upload a diff, not sure if > they used git diff or something else. > > Thank you. > > On Mon, Dec 19, 2011 at 1:49 PM, Patrick Hunt <[email protected]> wrote: >> Hi Dmitriy my experience, at least on ZooKeeper, is that we needed >> both a zookeeper and a zookeeper-git repository in order to support >> svn & git (respectively) in RB. Try pinging Infra, they can add this >> for you. >> >> Regards, >> >> Patrick >> >> On Mon, Dec 19, 2011 at 12:54 PM, Dmitriy Lyubimov <[email protected]> wrote: >>> the error i am getting is >>> >>> No valid separator after the filename was found in the diff header >>> >>> so it looks like it needs specific tweaks for a patch. However 'patch' >>> routine would apply my output cleanly. So i am at loss. >>> >>> -d >>> >>> On Mon, Dec 19, 2011 at 12:52 PM, Dmitriy Lyubimov <[email protected]> >>> wrote: >>>> ok it wouldn't eat up my git diff output no matter what i do. >>>> >>>> i tried git diff, git diff -p , git diff -p --no-prefix, git diff -u >>>> --no-prefix for base directories both / and /trunk, all of these >>>> combinations, to no avail. it looks like it doesn't like git diff >>>> output. >>>> >>>> Any ideas are welcome.
