I think that this is a fine solution (so is merging). I may have some time tonight.
On Wed, Jan 18, 2012 at 6:44 PM, Dawid Weiss (Commented) (JIRA) < [email protected]> wrote: > > [ > https://issues.apache.org/jira/browse/MAHOUT-768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188605#comment-13188605] > > Dawid Weiss commented on MAHOUT-768: > ------------------------------------ > > Err... I must have forgotten to attach a comment to jira for some reason. > Anyway, removing DoubleFunction from mahout.math works for me (the tests > pass at least) because math is dependent on collections anyway. This is not > a perfect solution, but it is a solution -- remove the duplicate > DoubleFunction from m.math. > > In the long run I'd vote for merging back collections. The fact certain > classes reside in the same package namespace seems to indicate they're > tightly coupled anyway. > > > Duplicated DoubleFunction in mahout and mahout-collections (mahout.math > package). > > > --------------------------------------------------------------------------------- > > > > Key: MAHOUT-768 > > URL: https://issues.apache.org/jira/browse/MAHOUT-768 > > Project: Mahout > > Issue Type: Improvement > > Components: collections, Math > > Affects Versions: 0.5, collections-1.0 > > Reporter: Dawid Weiss > > Assignee: Ted Dunning > > Priority: Minor > > Fix For: 0.6 > > > > > > DoubleFunction is duplicated in Mahout Math and Collections. There are > also other things inside m.math.* package that are kept there to avoid > circular dependencies... Simply removing DoubleFunction from collections is > not going to work because it is needed for compilation (again, circular > dependency between collections and math). I see two solutions: > > 1) extract the common definitions inside math.function.* into a separate > module. This is a clean solution, but obviously scatters the code even > further. > > 2) create a compilation-time, optional dependency on mahout 0.5 in > collections, remove the entire mahout.math.* subpackage from collections > and live with this. I don't know how Maven handles circular dependencies of > this type: > > collections [trunk] -> [optional, required at build time] mahout.math 0.5 > > mahout.math [trunk] -> collections [trunk] > > it seems tricky and error-prone, but should also work. > > Looking for other ideas of cleaning this mess up, of course. > > Dawid > > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA > administrators: > https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa > For more information on JIRA, see: http://www.atlassian.com/software/jira > > >
