[ 
https://issues.apache.org/jira/browse/MAHOUT-768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276738#comment-13276738
 ] 

Hudson commented on MAHOUT-768:
-------------------------------

Integrated in Mahout-Quality #1487 (See 
[https://builds.apache.org/job/Mahout-Quality/1487/])
    MAHOUT-768 - Merge collections into math. (Revision 1339121)

     Result = FAILURE
tdunning : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339121
Files : 
* /mahout/trunk/math/pom.xml
* 
/mahout/trunk/math/src/main/java-templates/org/apache/mahout/math/function/ValueTypeComparator.java.t
* 
/mahout/trunk/math/src/main/java-templates/org/apache/mahout/math/list/AbstractValueTypeList.java.t
* 
/mahout/trunk/math/src/main/java-templates/org/apache/mahout/math/list/ValueTypeArrayList.java.t
* 
/mahout/trunk/math/src/main/java-templates/org/apache/mahout/math/map/AbstractKeyTypeValueTypeMap.java.t
* 
/mahout/trunk/math/src/main/java-templates/org/apache/mahout/math/map/AbstractObjectValueTypeMap.java.t
* 
/mahout/trunk/math/src/main/java-templates/org/apache/mahout/math/map/OpenKeyTypeObjectHashMap.java.t
* 
/mahout/trunk/math/src/main/java-templates/org/apache/mahout/math/map/OpenKeyTypeValueTypeHashMap.java.t
* 
/mahout/trunk/math/src/main/java-templates/org/apache/mahout/math/map/OpenObjectValueTypeHashMap.java.t
* 
/mahout/trunk/math/src/main/java-templates/org/apache/mahout/math/set/AbstractKeyTypeSet.java.t
* 
/mahout/trunk/math/src/main/java-templates/org/apache/mahout/math/set/OpenKeyTypeHashSet.java.t
* /mahout/trunk/math/src/main/java/org/apache/mahout/collections
* /mahout/trunk/math/src/main/java/org/apache/mahout/collections/Arithmetic.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/collections/Constants.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/Arrays.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/GenericPermuting.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/PersistentObject.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/Sorting.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/Swapper.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/function/DoubleFunction.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/function/FloatFunction.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/function/Functions.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/function/ObjectObjectProcedure.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/function/ObjectProcedure.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/function/package.html
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/list
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/list/AbstractList.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/list/AbstractObjectList.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/list/ObjectArrayList.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/list/SimpleLongArrayList.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/list/package.html
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/map
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/map/HashFunctions.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/map/OpenHashMap.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/map/PrimeFinder.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/map/QuickOpenIntIntHashMap.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/map/package.html
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/DoubleMatrix1D.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/DoubleMatrix2D.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/impl/AbstractMatrix.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/impl/AbstractMatrix1D.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/impl/AbstractMatrix2D.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/impl/DelegateDoubleMatrix1D.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/impl/DenseDoubleMatrix1D.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/impl/DenseDoubleMatrix2D.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/impl/SelectedDenseDoubleMatrix1D.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/impl/SelectedDenseDoubleMatrix2D.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/impl/SelectedSparseDoubleMatrix1D.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/impl/SelectedSparseDoubleMatrix2D.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/impl/SparseDoubleMatrix1D.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/impl/SparseDoubleMatrix2D.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/impl/WrapperDoubleMatrix1D.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/impl/WrapperDoubleMatrix2D.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/impl/package-info.java
* 
/mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/linalg/Property.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/package.html
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/set
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/set/AbstractSet.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/set/OpenHashSet.java

                
> Duplicated DoubleFunction in mahout and mahout-collections (mahout.math 
> package).
> ---------------------------------------------------------------------------------
>
>                 Key: MAHOUT-768
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-768
>             Project: Mahout
>          Issue Type: Improvement
>          Components: collections, Math
>    Affects Versions: 0.5, collections-1.0
>            Reporter: Dawid Weiss
>            Assignee: Ted Dunning
>            Priority: Minor
>             Fix For: 0.7
>
>
> DoubleFunction is duplicated in Mahout Math and Collections. There are also 
> other things inside m.math.* package that are kept there to avoid circular 
> dependencies... Simply removing DoubleFunction from collections is not going 
> to work because it is needed for compilation (again, circular dependency 
> between collections and math). I see two solutions:
> 1) extract the common definitions inside math.function.* into a separate 
> module. This is a clean solution, but obviously scatters the code even 
> further.
> 2) create a compilation-time, optional dependency on mahout 0.5 in 
> collections, remove the entire mahout.math.* subpackage from collections and 
> live with this. I don't know how Maven handles circular dependencies of this 
> type:
> collections [trunk] -> [optional, required at build time] mahout.math 0.5
> mahout.math [trunk] -> collections [trunk]
> it seems tricky and error-prone, but should also work.
> Looking for other ideas of cleaning this mess up, of course.
> Dawid

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to