[ 
https://issues.apache.org/jira/browse/MAHOUT-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240040#comment-13240040
 ] 

Dmitriy Lyubimov commented on MAHOUT-994:
-----------------------------------------

Sounds good to me. 

The only concern i have is to verify that local stuff is not broken when run 
from command line. I don't think this is verified by build unit tests. The 
history of local mode in Mahout is a little bit out of my scope, i will need 
another person to assertain the change for the local mode.

But what you are saying sounds very benign to me. Thank you for doing this. 
When you submit a patch, do you think you could also create a review request 
for Mahout? Hopefully this will encourage another pair of eyes to look at it. 
if nobody responds, let me know, i will try to locate another pair of eyes for 
it. 

Again, thank you for doing this, Hadoop best practices may sometimes be hard to 
figure.
                
> mahout script shouldn't rely on HADOOP_HOME since that was deprecated in all 
> major Hadoop branches
> --------------------------------------------------------------------------------------------------
>
>                 Key: MAHOUT-994
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-994
>             Project: Mahout
>          Issue Type: Bug
>          Components: Integration
>    Affects Versions: 0.6
>            Reporter: Roman Shaposhnik
>
> Mahout should follow the Pig and Hive example and not rely explicitly on 
> HADOOP_HOME and HADOOP_CONF_DIR

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to