[ 
https://issues.apache.org/jira/browse/MAHOUT-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262230#comment-13262230
 ] 

[email protected] commented on MAHOUT-994:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4632/#review7247
-----------------------------------------------------------


Looks good aside from the one issue below.  


trunk/bin/mahout
<https://reviews.apache.org/r/4632/#comment16017>

    Think we need to omit HADOOP_BINARY_CLASSPATH here; otherwise I get an 
error due to my cluster and Mahout HDFS libs having different API versions when 
I run with MAHOUT_LOCAL set.  


- tom


On 2012-04-04 00:26:36, Roman Shaposhnik wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4632/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-04-04 00:26:36)
bq.  
bq.  
bq.  Review request for mahout and tom pierce.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Patch according to the JIRA discussion.
bq.  
bq.  
bq.  This addresses bug MAHOUT-994.
bq.      https://issues.apache.org/jira/browse/MAHOUT-994
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/bin/mahout 1309189 
bq.    trunk/distribution/src/main/assembly/bin.xml 1309189 
bq.  
bq.  Diff: https://reviews.apache.org/r/4632/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  build and execution in various modes
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Roman
bq.  
bq.


                
> mahout script shouldn't rely on HADOOP_HOME since that was deprecated in all 
> major Hadoop branches
> --------------------------------------------------------------------------------------------------
>
>                 Key: MAHOUT-994
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-994
>             Project: Mahout
>          Issue Type: Bug
>          Components: Integration
>    Affects Versions: 0.6
>            Reporter: Roman Shaposhnik
>         Attachments: MAHOUT-994.patch.txt
>
>
> Mahout should follow the Pig and Hive example and not rely explicitly on 
> HADOOP_HOME and HADOOP_CONF_DIR

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to