[
https://issues.apache.org/jira/browse/MAHOUT-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13681441#comment-13681441
]
Ted Dunning commented on MAHOUT-1257:
-------------------------------------
Attaching a patch involves attaching a file named something like
MAHOUT-1257.patch.
To attach a file, look under "More Actions".
Your change is fine, but distinguishing variables by difference in case is a
spanking offense.
Much better to pick a more descriptive term like np1 for n-p1. Or better yet,
consider row1 for p1 and do the subtraction in place without worrying about
naming it.
> performance improvement to LogLikehood
> --------------------------------------
>
> Key: MAHOUT-1257
> URL: https://issues.apache.org/jira/browse/MAHOUT-1257
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Reporter: Mike Sokolov
>
> This patch reduces the amount of computation required for LLR. It simplifies
> the math by canceling terms. In a microbenchmark we saw an 18% run time
> improvement.
> I couldn't seem to find the UI for uploading a patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
