[ 
https://issues.apache.org/jira/browse/MAHOUT-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13681459#comment-13681459
 ] 

Mike Sokolov commented on MAHOUT-1257:
--------------------------------------

OK, consider me spanked.  I made the variable names more explicit.  I didn't 
use the in-place subtraction because it would require another addition (as 
coded, N depends on the intermediate variable formerly known as P1, now non1).  
Seems silly, but since the whole point of the patch is to reduce the number of 
arithmetic operations...
                
> performance improvement to LogLikehood
> --------------------------------------
>
>                 Key: MAHOUT-1257
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1257
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Math
>            Reporter: Mike Sokolov
>         Attachments: MAHOUT-1257.patch
>
>
> This patch reduces the amount of computation required for LLR. It simplifies 
> the math by canceling terms.  In a microbenchmark we saw an 18% run time 
> improvement.
> I couldn't seem to find the UI for uploading a patch file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to