[ 
https://issues.apache.org/jira/browse/MAHOUT-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829606#comment-13829606
 ] 

Suneel Marthi commented on MAHOUT-1345:
---------------------------------------

[~isabel][~sslavic] Applied this patch and I am now seeing random test 
failures. I am running on Mac OS 10.8 Mountain Lion.

{Code}

Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.96 sec <<< 
FAILURE! - in org.apache.mahout.text.LuceneSegmentInputFormatTest
testGetSplits(org.apache.mahout.text.LuceneSegmentInputFormatTest)  Time 
elapsed: 3.295 sec  <<< ERROR!
com.carrotsearch.randomizedtesting.ThreadLeakError: 1 thread leaked from TEST 
scope at testGetSplits(org.apache.mahout.text.LuceneSegmentInputFormatTest): 
   1) Thread[id=14, name=AWT-Shutdown, state=TIMED_WAITING, group=main]
        at java.lang.Object.wait(Native Method)
        at sun.awt.AWTAutoShutdown.run(AWTAutoShutdown.java:284)
        at java.lang.Thread.run(Thread.java:695)
        at 
__randomizedtesting.SeedInfo.seed([D01FBCB7576C7478:647C7E93467BBD35]:0)

Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.649 sec <<< 
FAILURE! - in org.apache.mahout.text.LuceneSegmentInputSplitTest
testGetSegmentNonExistingSegment(org.apache.mahout.text.LuceneSegmentInputSplitTest)
  Time elapsed: 3.571 sec  <<< ERROR!
com.carrotsearch.randomizedtesting.ThreadLeakError: 1 thread leaked from TEST 
scope at 
testGetSegmentNonExistingSegment(org.apache.mahout.text.LuceneSegmentInputSplitTest):
 
   1) Thread[id=14, name=AWT-Shutdown, state=TIMED_WAITING, group=main]
        at java.lang.Object.wait(Native Method)
        at sun.awt.AWTAutoShutdown.run(AWTAutoShutdown.java:284)
        at java.lang.Thread.run(Thread.java:695)
        at 
__randomizedtesting.SeedInfo.seed([760C118FE5998411:31C8F60AD35952AF]:0)

Running org.apache.mahout.utils.email.MailProcessorTest
Running org.apache.mahout.utils.nlp.collocations.llr.BloomTokenFilterTest
Running org.apache.mahout.utils.regex.RegexMapperTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.902 sec - in 
org.apache.mahout.utils.email.MailProcessorTest
Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 6.855 sec <<< 
FAILURE! - in org.apache.mahout.text.LuceneSegmentRecordReaderTest
testNonExistingField(org.apache.mahout.text.LuceneSegmentRecordReaderTest)  
Time elapsed: 0.955 sec  <<< ERROR!
com.carrotsearch.randomizedtesting.ThreadLeakError: 1 thread leaked from TEST 
scope at 
testNonExistingField(org.apache.mahout.text.LuceneSegmentRecordReaderTest): 
   1) Thread[id=17, name=AWT-Shutdown, state=TIMED_WAITING, group=main]
        at java.lang.Object.wait(Native Method)
        at sun.awt.AWTAutoShutdown.run(AWTAutoShutdown.java:284)
        at java.lang.Thread.run(Thread.java:695)
        at 
__randomizedtesting.SeedInfo.seed([BAD70A9A105E6C9:F7B1E5646F3C1F87]:0)

Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.005 sec - in 
org.apache.mahout.text.SequenceFilesFromMailArchivesTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.007 sec - in 
org.apache.mahout.utils.nlp.collocations.llr.BloomTokenFilterTest
Tests run: 5, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 8.123 sec <<< 
FAILURE! - in org.apache.mahout.text.SequenceFilesFromLuceneStorageDriverTest
testNewLucene2SeqConfiguration(org.apache.mahout.text.SequenceFilesFromLuceneStorageDriverTest)
  Time elapsed: 3.33 sec  <<< ERROR!
com.carrotsearch.randomizedtesting.ThreadLeakError: 1 thread leaked from TEST 
scope at 
testNewLucene2SeqConfiguration(org.apache.mahout.text.SequenceFilesFromLuceneStorageDriverTest):
 
   1) Thread[id=14, name=AWT-Shutdown, state=TIMED_WAITING, group=main]
        at java.lang.Object.wait(Native Method)
        at sun.awt.AWTAutoShutdown.run(AWTAutoShutdown.java:284)
        at java.lang.Thread.run(Thread.java:695)
        at 
__randomizedtesting.SeedInfo.seed([E764A6A6A163BB7D:C2C9DD1521FA15E]:0)

testRunOptionalArguments(org.apache.mahout.text.SequenceFilesFromLuceneStorageDriverTest)
  Time elapsed: 2.256 sec  <<< ERROR!
com.carrotsearch.randomizedtesting.ThreadLeakError: 1 thread leaked from TEST 
scope at 
testRunOptionalArguments(org.apache.mahout.text.SequenceFilesFromLuceneStorageDriverTest):
 
   1) Thread[id=20, name=AWT-Shutdown, state=TIMED_WAITING, group=main]
        at java.lang.Object.wait(Native Method)
        at sun.awt.AWTAutoShutdown.run(AWTAutoShutdown.java:284)
        at java.lang.Thread.run(Thread.java:695)
        at 
__randomizedtesting.SeedInfo.seed([E764A6A6A163BB7D:92E891124EB97769]:0)

testRunInvalidQuery(org.apache.mahout.text.SequenceFilesFromLuceneStorageDriverTest)
  Time elapsed: 1.416 sec  <<< ERROR!
com.carrotsearch.randomizedtesting.ThreadLeakError: 2 threads leaked from TEST 
scope at 
testRunInvalidQuery(org.apache.mahout.text.SequenceFilesFromLuceneStorageDriverTest):
 
   1) Thread[id=25, name=communication thread, state=TIMED_WAITING, 
group=TGRP-SequenceFilesFromLuceneStorageDriverTest]
        at java.lang.Object.wait(Native Method)
        at org.apache.hadoop.mapred.Task$TaskReporter.run(Task.java:658)
        at java.lang.Thread.run(Thread.java:695)
   2) Thread[id=26, name=communication thread, state=TIMED_WAITING, 
group=TGRP-SequenceFilesFromLuceneStorageDriverTest]
        at java.lang.Object.wait(Native Method)
        at org.apache.hadoop.mapred.Task$TaskReporter.run(Task.java:658)
        at java.lang.Thread.run(Thread.java:695)
        at 
__randomizedtesting.SeedInfo.seed([E764A6A6A163BB7D:F45193CA73B3494C]:0)

{Code}

> Enable randomised testing for all Mahout modules
> ------------------------------------------------
>
>                 Key: MAHOUT-1345
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1345
>             Project: Mahout
>          Issue Type: Improvement
>    Affects Versions: 0.8
>            Reporter: Isabel Drost-Fromm
>            Priority: Minor
>             Fix For: 0.9
>
>         Attachments: MAHOUT-1345.diff
>
>
> When enabling randomised testing for all modules I found a few tests became 
> unstable or even fail deterministically due to lingering threads. The 
> attached patch:
> * defines the randomised testing dependency in our parent pom
> * re-uses said dependencies in all depending modules (makes upgrading easier 
> as the version number needs to be changed in just one place)
> * adds several code changes that fixed the failures due to lingering threads 
> for me on my machine. I'd greatly appreciate input a) from those who wrote 
> the respective code and b) others who ran the tests with these changes to 
> make sure there are no other tests that suffer from the same issues. 
> Warning: I touched quite a few bits and pieces I'm not intimately familiar 
> with over the last few weeks  (whenever I had a few spare minutes) - second 
> pair of eyes needed.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to