[ 
https://issues.apache.org/jira/browse/MAHOUT-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830978#comment-13830978
 ] 

Frank Scholten commented on MAHOUT-1345:
----------------------------------------

I applied the pacth, ran a mvn clean install on Ubuntu 13.04 and OpenJDK 
1.7.0_25 and got this stacktrace:

{code:java}
17:28:25 Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 79.239 
sec <<< FAILURE! - in org.apache.mahout.clustering.lda.cvb.TestCVBModelTrainer
17:28:25 
testInMemoryCVB0(org.apache.mahout.clustering.lda.cvb.TestCVBModelTrainer)  
Time elapsed: 13.716 sec  <<< ERROR!
17:28:25 com.carrotsearch.randomizedtesting.ThreadLeakError: 1 thread leaked 
from TEST scope at 
testInMemoryCVB0(org.apache.mahout.clustering.lda.cvb.TestCVBModelTrainer): 
17:28:25    1) Thread[id=358, name=pool-154-thread-1, state=RUNNABLE, 
group=TGRP-TestCVBModelTrainer]
17:28:25         at sun.misc.Unsafe.unpark(Native Method)
17:28:25         at 
java.util.concurrent.locks.LockSupport.unpark(LockSupport.java:152)
17:28:25         at 
java.util.concurrent.locks.AbstractQueuedSynchronizer.unparkSuccessor(AbstractQueuedSynchronizer.java:662)
17:28:25         at 
java.util.concurrent.locks.AbstractQueuedSynchronizer.release(AbstractQueuedSynchronizer.java:1263)
17:28:25         at 
java.util.concurrent.locks.ReentrantLock.unlock(ReentrantLock.java:460)
17:28:25         at 
java.util.concurrent.ThreadPoolExecutor.tryTerminate(ThreadPoolExecutor.java:712)
17:28:25         at 
java.util.concurrent.ThreadPoolExecutor.processWorkerExit(ThreadPoolExecutor.java:1006)
17:28:25         at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1163)
17:28:25         at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
17:28:25         at java.lang.Thread.run(Thread.java:724)
17:28:25        at 
__randomizedtesting.SeedInfo.seed([E9C2EFFF8F543D07:7939EAE64DE10951]:0)
{code}

I don't know how to interpret this yet. I'll read up [~dweiss]' code and docs 
on randomized testing first. Would be nice feature!

A few links I am looking at:

http://labs.carrotsearch.com/randomizedtesting-concept.html
https://github.com/carrotsearch/randomizedtesting/tree/master/examples/maven/src/main/java/com/carrotsearch/examples/randomizedrunner


> Enable randomised testing for all Mahout modules
> ------------------------------------------------
>
>                 Key: MAHOUT-1345
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1345
>             Project: Mahout
>          Issue Type: Improvement
>    Affects Versions: 0.8
>            Reporter: Isabel Drost-Fromm
>            Priority: Minor
>             Fix For: 0.9
>
>         Attachments: MAHOUT-1345.diff, MAHOUT-1345.patch
>
>
> When enabling randomised testing for all modules I found a few tests became 
> unstable or even fail deterministically due to lingering threads. The 
> attached patch:
> * defines the randomised testing dependency in our parent pom
> * re-uses said dependencies in all depending modules (makes upgrading easier 
> as the version number needs to be changed in just one place)
> * adds several code changes that fixed the failures due to lingering threads 
> for me on my machine. I'd greatly appreciate input a) from those who wrote 
> the respective code and b) others who ran the tests with these changes to 
> make sure there are no other tests that suffer from the same issues. 
> Warning: I touched quite a few bits and pieces I'm not intimately familiar 
> with over the last few weeks  (whenever I had a few spare minutes) - second 
> pair of eyes needed.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to