[
https://issues.apache.org/jira/browse/MAHOUT-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260278#comment-14260278
]
ASF GitHub Bot commented on MAHOUT-1636:
----------------------------------------
Github user andrewpalumbo commented on the pull request:
https://github.com/apache/mahout/pull/69#issuecomment-68280984
Ok cool.. yeah i cant see why it wouldnt work then. Will get caught up and
check it when I get back.
Sent from my Verizon Wireless 4G LTE smartphone
<div>-------- Original message --------</div><div>From: Pat Ferrel
<[email protected]> </div><div>Date:12/29/2014 12:43 PM (GMT-05:00)
</div><div>To: apache/mahout <[email protected]> </div><div>Cc: Andrew
Palumbo <[email protected]> </div><div>Subject: Re: [mahout] MAHOUT-1636 (#69)
</div><div>
</div>Yep, it applies. Any time you launch from the command line. The
scalatests won't catch this case but since you haven't messed with the pom or
added any external deps your 99% sure to be ok.
Probably too soon to try it for the nb stuff. There are a few other tweaks
but wanted comments asap.
—
Reply to this email directly or view it on GitHub.
> Class dependencies for the spark module are put in a job.jar, which is very
> inefficient
> ---------------------------------------------------------------------------------------
>
> Key: MAHOUT-1636
> URL: https://issues.apache.org/jira/browse/MAHOUT-1636
> Project: Mahout
> Issue Type: Bug
> Components: spark
> Affects Versions: 1.0-snapshot
> Reporter: Pat Ferrel
> Assignee: Ted Dunning
> Fix For: 1.0-snapshot
>
>
> using a maven plugin and an assembly job.xml a job.jar is created with all
> dependencies including transitive ones. This job.jar is in
> mahout/spark/target and is included in the classpath when a Spark job is run.
> This allows dependency classes to be found at runtime but the job.jar include
> a great deal of things not needed that are duplicates of classes found in the
> main mrlegacy job.jar. If the job.jar is removed, drivers will not find
> needed classes. A better way needs to be implemented for including class
> dependencies.
> I'm not sure what that better way is so am leaving the assembly alone for
> now. Whoever picks up this Jira will have to remove it after deciding on a
> better method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
