[
https://issues.apache.org/jira/browse/MAHOUT-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14582356#comment-14582356
]
ASF GitHub Bot commented on MAHOUT-1660:
----------------------------------------
Github user dlyubimov commented on a diff in the pull request:
https://github.com/apache/mahout/pull/135#discussion_r32253651
--- Diff: h2o/src/main/java/org/apache/mahout/h2obindings/drm/H2OBCast.java
---
@@ -118,4 +118,16 @@ private T deserialize(byte buf[]) {
}
return ret;
}
+
+ /**
+ * Stop broadcasting when called on driver side. Release any network
resources.
+ *
+ */
+ @Override
+ public void close() throws IOException {
+
+ // TODO: review this. It looks like it is not really a broadcast
mechanism but rather just a
--- End diff --
I am not sure how h20 does it but it looks like broadcast is just
serialized to the backend with all requests, not really broadcasted. if so,
there are no associated resources so method needs to do nothing. Anyhow it's
something for Anand @avati to look at.
> Hadoop1HDFSUtil.readDRMHEader should be taking Hadoop conf
> ----------------------------------------------------------
>
> Key: MAHOUT-1660
> URL: https://issues.apache.org/jira/browse/MAHOUT-1660
> Project: Mahout
> Issue Type: Bug
> Components: spark
> Affects Versions: 0.10.0
> Reporter: Suneel Marthi
> Assignee: Dmitriy Lyubimov
> Priority: Minor
> Fix For: 0.10.2
>
>
> Hadoop1HDFSUtil.readDRMHEader should be taking Hadoop configuration from
> Context and not ignore it
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
