[ 
https://issues.apache.org/jira/browse/MAHOUT-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582758#comment-15582758
 ] 

ASF GitHub Bot commented on MAHOUT-1885:
----------------------------------------

Github user andrewpalumbo commented on the issue:

    https://github.com/apache/mahout/pull/261
  
    I don't think  that cyclical referencing is an issue.  There are other ways 
to get the class onto the path.  They just got dropped somehow when I was 
creating/reason the pr.  For now though adding the dependency at test time 
works for me just to make sure everything's working.
    
    
    
    Sent from my Verizon Wireless 4G LTE smartphone
    
    
    -------- Original message --------
    From: Trevor Grant <notificati...@github.com>
    Date: 10/16/2016 9:54 PM (GMT-08:00)
    To: apache/mahout <mah...@noreply.github.com>
    Cc: Andrew Palumbo <ap....@outlook.com>, Author <aut...@noreply.github.com>
    Subject: Re: [apache/mahout] MAHOUT-1885 [WIP][FOR COMMENT]: Inital 
implementation of VCL bindings for mahout math. (#261)
    
    
    @rawkintrevo commented on this pull request.
    
    ________________________________
    
    In 
math-scala/src/main/scala/org/apache/mahout/math/scalabindings/SolverFactory.scala<https://github.com/apache/mahout/pull/261>:
    
    > +  // just temp for quick POC
    +  val classMap: Map[String,String] =
    +    Map(("GPUMMul"->"org.apache.mahout.viennacl.opencl.GPUMMul"),
    +        ("OMPMMul"->"org.apache.mahout.viennacl.openmp.OMPMMul"))
    +}
    +object SolverFactory extends SolverFactory {
    +
    +    // default is JVM
    +    var clazz: MMBinaryFunc = MMul
    +
    +    // eventually match on implicit Classtag . for now.  just take as is.
    +    // this is a bit hacky, Shoud not be doing onlytry/catch here..
    +    def getOperator[C: ClassTag]: MMBinaryFunc = {
    +
    +      try {
    +        println("creating org.apache.mahout.viennacl.opencl.GPUMMul 
solver")
    
    
    given the cyclical reference issues, maybe a solution here should come 
sooner rather than later (e.g. solving this, would also 'fix' the cyclical 
reference problem?)
    
    —
    You are receiving this because you authored the thread.
    Reply to this email directly, view it on 
GitHub<https://github.com/apache/mahout/pull/261>, or mute the 
thread<https://github.com/notifications/unsubscribe-auth/AHU2HXNDs1M9yqQjTnKl6onfaOeAjtKQks5q0v-LgaJpZM4KSKUm>.



> Inital Implementation of VCL Bindings
> -------------------------------------
>
>                 Key: MAHOUT-1885
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1885
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Math
>    Affects Versions: 0.12.2
>            Reporter: Andrew Palumbo
>            Assignee: Andrew Palumbo
>             Fix For: 0.13.0
>
>
> Push a working experimental branch of VCL bindings into master.  There is 
> still a lot of work to be done.  All tests are passing, At the moment there 
> am opening this JIRA mostly to get a number for PR and to test profiles 
> against on travis. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to