[ 
https://issues.apache.org/jira/browse/MAHOUT-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581210#comment-15581210
 ] 

ASF GitHub Bot commented on MAHOUT-1885:
----------------------------------------

Github user rawkintrevo commented on a diff in the pull request:

    https://github.com/apache/mahout/pull/261#discussion_r83577666
  
    --- Diff: 
math-scala/src/main/scala/org/apache/mahout/math/scalabindings/SolverFactory.scala
 ---
    @@ -0,0 +1,71 @@
    +/**
    +  * Licensed to the Apache Software Foundation (ASF) under one or more
    +  * contributor license agreements.  See the NOTICE file distributed with
    +  * this work for additional information regarding copyright ownership.
    +  * The ASF licenses this file to You under the Apache License, Version 2.0
    +  * (the "License"); you may not use this file except in compliance with
    +  * the License.  You may obtain a copy of the License at
    +  *
    +  * http://www.apache.org/licenses/LICENSE-2.0
    +  *
    +  * Unless required by applicable law or agreed to in writing, software
    +  * distributed under the License is distributed on an "AS IS" BASIS,
    +  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
    +  * See the License for the specific language governing permissions and
    +  * limitations under the License.
    +  */
    +package org.apache.mahout.math.scalabindings
    +
    +import java.io.File
    +
    +import org.apache.mahout.logging._
    +
    +import scala.reflect.ClassTag
    +import scala.reflect.runtime._
    +import scala.reflect._
    +
    +
    +class SolverFactory {
    +
    +  private final implicit val log = getLog(this.getClass)
    +
    +  // just temp for quick POC
    +  val classMap: Map[String,String] =
    +    Map(("GPUMMul"->"org.apache.mahout.viennacl.opencl.GPUMMul"),
    +        ("OMPMMul"->"org.apache.mahout.viennacl.openmp.OMPMMul"))
    +}
    +object SolverFactory extends SolverFactory {
    +
    +    // default is JVM
    +    var clazz: MMBinaryFunc = MMul
    +
    +    // eventually match on implicit Classtag . for now.  just take as is.
    +    // this is a bit hacky, Shoud not be doing onlytry/catch here..
    +    def getOperator[C: ClassTag]: MMBinaryFunc = {
    +
    +      try {
    +        println("creating org.apache.mahout.viennacl.opencl.GPUMMul 
solver")
    --- End diff --
    
    given the cyclical reference issues, maybe a solution here should come 
sooner rather than later (e.g. solving this, would also 'fix' the cyclical 
reference problem?)


> Inital Implementation of VCL Bindings
> -------------------------------------
>
>                 Key: MAHOUT-1885
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1885
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Math
>    Affects Versions: 0.12.2
>            Reporter: Andrew Palumbo
>            Assignee: Andrew Palumbo
>             Fix For: 0.13.0
>
>
> Push a working experimental branch of VCL bindings into master.  There is 
> still a lot of work to be done.  All tests are passing, At the moment there 
> am opening this JIRA mostly to get a number for PR and to test profiles 
> against on travis. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to