[
https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061714#comment-16061714
]
ASF GitHub Bot commented on MAHOUT-1988:
----------------------------------------
Github user rawkintrevo commented on a diff in the pull request:
https://github.com/apache/mahout/pull/326#discussion_r123866703
--- Diff:
viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala
---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
@Name(Array("viennacl::matrix<double,viennacl::column_major>"))
final class DenseColumnMatrix(initDefault:Boolean = true) extends
MatrixBase {
- def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+ def this(nrow: Int, ncol: Int) {
+ this(false)
+ allocate(nrow, ncol, new Context())
+ }
+
+ def this(nrow: Int, ncol: Int, ctx: Context) {
this(false)
allocate(nrow, ncol, ctx)
}
- def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new
Context(Context.MAIN_MEMORY)) {
--- End diff --
@andrewpalumbo thanks for the review
If you look at line 49 and 56 below- this is what replaces. Line 49 lets
you call the constructor with out a default context (same as what happened
here) line 56 lets you explicitly pass a context.
Re: Scala 2.11.2, I made a comment on MAHOUT-1975. We probably need to
figure out where the dependency comes from and try to work around it.
Will also dig in on my end- viennacl always fails for me bc I don't have
strong enough GPUs- but results should be same for ViennaCL-OMP.
> ViennaCL and OMP not building for Scala 2.11
> --------------------------------------------
>
> Key: MAHOUT-1988
> URL: https://issues.apache.org/jira/browse/MAHOUT-1988
> Project: Mahout
> Issue Type: Bug
> Affects Versions: 0.13.0
> Reporter: Andrew Palumbo
> Assignee: Trevor Grant
> Priority: Blocker
> Fix For: 0.13.1
>
>
> After building mahout against scala 2.11:
> {code}
> mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11
> -Phadoop2 -DskipTests
> {code}
> ViennaCL jars are built hard-coded to scala 2.10. This is currently blocking
> the 0.13.1 release.
> {code}
> mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
> mahout-hdfs-0.13.1-SNAPSHOT.jar
> mahout-math-0.13.1-SNAPSHOT.jar
> mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
> mahout-mr-0.13.1-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT.jar
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
