[
https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062164#comment-16062164
]
ASF GitHub Bot commented on MAHOUT-1988:
----------------------------------------
Github user andrewpalumbo commented on a diff in the pull request:
https://github.com/apache/mahout/pull/326#discussion_r123887027
--- Diff:
viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala
---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
@Name(Array("viennacl::matrix<double,viennacl::column_major>"))
final class DenseColumnMatrix(initDefault:Boolean = true) extends
MatrixBase {
- def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+ def this(nrow: Int, ncol: Int) {
+ this(false)
+ allocate(nrow, ncol, new Context())
+ }
+
+ def this(nrow: Int, ncol: Int, ctx: Context) {
this(false)
allocate(nrow, ncol, ctx)
}
- def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new
Context(Context.MAIN_MEMORY)) {
--- End diff --
@rawkintrevo lgtm - ship it! we swill still need to do some testing against
other spark versions though. As well, there are some other issues that I've
noticed, but can be addressed in other PRs on top of this anyways, eg. #327.
> ViennaCL and OMP not building for Scala 2.11
> --------------------------------------------
>
> Key: MAHOUT-1988
> URL: https://issues.apache.org/jira/browse/MAHOUT-1988
> Project: Mahout
> Issue Type: Bug
> Affects Versions: 0.13.0
> Reporter: Andrew Palumbo
> Assignee: Trevor Grant
> Priority: Blocker
> Fix For: 0.13.1
>
>
> After building mahout against scala 2.11:
> {code}
> mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11
> -Phadoop2 -DskipTests
> {code}
> ViennaCL jars are built hard-coded to scala 2.10. This is currently blocking
> the 0.13.1 release.
> {code}
> mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
> mahout-hdfs-0.13.1-SNAPSHOT.jar
> mahout-math-0.13.1-SNAPSHOT.jar
> mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
> mahout-mr-0.13.1-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT.jar
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
