ryankert01 commented on code in PR #756: URL: https://github.com/apache/mahout/pull/756#discussion_r2645499351
########## qdp/DEVELOPMENT.md: ########## @@ -71,22 +97,36 @@ uv sync --group dev uv run maturin develop ``` +Alternatively, you can directly run the following command from the `qdp/` directory: + +```bash +make install +``` + ## Test There are two types of tests in mahout qdp: unit tests and e2e tests (benchmark tests). ### Unit Tests -You can simply follow the instructions in [test docs](./docs/test/README.md) to run unit tests. +You can use the following make commands from the `qdp/` directory: + +```bash +make unit_test # Run all unit tests (Python + Rust) +make unit_test_python # Run Python tests only +make unit_test_rust # Run Rust tests only Review Comment: nits ```suggestion make test # Run all unit tests (Python + Rust) make test_python # Run Python tests only make test_rust # Run Rust tests only ``` ########## qdp/DEVELOPMENT.md: ########## @@ -105,6 +145,12 @@ python benchmark_dataloader_throughput.py python benchmark_e2e.py ``` +Or use the make command from the `qdp/` directory: + +```bash +make e2e_test Review Comment: Our benchmarks are not stable right now, we might use different benchmark command. so I don't think we need this in make. eg. tryout different qubits`python e2e.py --qubits 100` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
