ryankert01 commented on code in PR #756:
URL: https://github.com/apache/mahout/pull/756#discussion_r2645566518
##########
qdp/Makefile:
##########
@@ -0,0 +1,59 @@
+.PHONY: install build build_nvtx_profile run_nvtx_profile unit_test
unit_test_python unit_test_rust e2e_test clean help
+
+help:
+ @echo "Available targets:"
+ @echo " make install - Install the mahout python package"
+ @echo " make build - Build qdp-core"
+ @echo " make build_nvtx_profile - Build qdp-core with observability
features"
+ @echo " make run_nvtx_profile - Build example, run with nsys, and
show stats (EXAMPLE=nvtx_profile)"
+ @echo " make unit_test - Run all unit tests (Python + Rust)"
+ @echo " make unit_test_python - Run Python unit tests only"
+ @echo " make unit_test_rust - Run Rust unit tests only"
+ @echo " make e2e_test - Run all e2e tests under
qdp-python/benchmark"
+ @echo " make clean - Clean build artifacts"
+
+install:
+ @echo "Installing mahout python package..."
+ cd qdp-python && uv sync --group dev
+ cd qdp-python && uv run maturin develop
+
+build:
+ @echo "Building qdp-core..."
+ cargo build -p qdp-core
+
+build_nvtx_profile:
+ @echo "Building qdp-core with observability features..."
+ cargo build -p qdp-core --features observability --release
+
+unit_test: unit_test_python unit_test_rust
+
+unit_test_python:
+ @echo "Running Python unit tests..."
+ cd qdp-python && uv run pytest tests/
+
+unit_test_rust:
+ @echo "Running Rust unit tests..."
+ cargo test --workspace
+
+e2e_test:
+ @echo "Running e2e benchmark tests..."
+ cd qdp-python/benchmark && uv run python benchmark_e2e.py
+ cd qdp-python/benchmark && uv run python
benchmark_dataloader_throughput.py
Review Comment:
```suggestion
install_benchmark:
cd qdp/qdp-python && uv sync --group benchmark
benchmark: install_benchmark
@echo "Running e2e benchmark tests..."
uv run python qdp-python/benchmark/benchmark_e2e.py
uv run python qdp-python/benchmark/benchmark_dataloader_throughput.py
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
