[ 
https://issues.apache.org/jira/browse/CONNECTORS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853097#comment-13853097
 ] 

Karl Wright commented on CONNECTORS-840:
----------------------------------------

The HttpPoster class got a lot more complex when the SolrJ integration 
happened.  Before that it was basically a class that formed multi-part posts.  
As you've seen, while its functionality is quite clear, it is not really very 
easy to refactor it into bite-sized pieces, because of how the SolrJ library 
works.

Much of ManifoldCF defies easy construction of unit tests for similar reasons, 
which is why we've opted to concentrate on integration testing instead of unit 
testing as the best way to assure quality.

If you provide a patch, I will certainly review it and if needed make 
recommendations before committing it.

Thanks!

> Job - Solr Mapping Improvement
> ------------------------------
>
>                 Key: CONNECTORS-840
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-840
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Solr-4.x-component
>    Affects Versions: ManifoldCF 1.4.1
>            Reporter: Alessandro Benedetti
>            Assignee: Karl Wright
>            Priority: Minor
>              Labels: field, mapping, request, solr, update
>             Fix For: ManifoldCF 1.5
>
>
> "When you configure a job to use a Solr-type output connection, the Solr 
> connection type provides a tab called "Field Mapping". The purpose of this 
> tab is to allow you to map metadata fields as fetched by the job's connection 
> type to fields that Solr is set up to receive. This is necessary because the 
> names of the metadata items are often determined by the repository, with no 
> alignment to fields defined in the Solr schema. You may also suppress 
> specific metadata items from being sent to the index using this tab. 
> Add a new mapping by filling in the "source" with the name of the metadata 
> item from the repository, and "target" as the name of the output field in 
> Solr, and click the "Add" button. Leaving the "target" field blank will 
> result in all metadata items of that name not being sent to Solr."
> In my opinion we should change the way a metadata field is suppressed.
> The most natural way is that we express only the mappings of the metadata 
> fields we want to keep.
> All the missing params will not be sent to Solr.
> The improvement will be :
> - same interface with a boolean flag in addition, this flag will specify if 
> the missing metadata fields not expressed should be sent to Solr with the 
> original names or not sent at all.
> In this way if we want to keep 3/100 metadata fields, we don't have to write 
> 100 mapping entries , 97 empty but simply 3 entries and activate the flag.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to