[
https://issues.apache.org/jira/browse/CONNECTORS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864437#comment-13864437
]
Karl Wright commented on CONNECTORS-840:
----------------------------------------
Thanks for the patch.
One comment so far. The change to common_en_US.properties looks incorrect to
me, since it removes many strings that are actually used, e.g.:
{code}
-SolrConnector.PleaseSupplyAValidSolrServerName=Please supply a valid Solr
server name
-SolrConnector.SolrServerPortMustBeAValidInteger=Solr server port must be a
valid integer
-SolrConnector.WebApplicationNameCannotHaveCharacters=Web application name
cannot have '/' characters
SolrConnector.CoreNameCannotHaveCharacters=Core name cannot have '/' characters
-SolrConnector.WebApplicationMustBeSpecifiedIfCoreIsSpecified=Web application
must be specified if core is specified
-SolrConnector.UpdatePathMustStartWithACharacter=Update path must start with a
'/' character
{code}
These are obviously still used:
{code}
C:\wip\mcf\trunk\connectors\solr\connector\src\main\java\org\apache\manifoldcf\agents\output\solr>grep
"PleaseSupply" *.java
SolrConnector.java:"
alert(\""+Messages.getBodyJavascriptString(locale,"SolrConnector.PleaseSupplyAValidSolrServerName")+"\");\n"+
SolrConnector.java:"
alert(\""+Messages.getBodyJavascriptString(locale,"SolrConnector.PleaseSupplyAValidSolrServerName")+"\");\n"+
{code}
Can you correct your patch to be more careful about removing translations that
are needed?
Thanks again!
> Job - Solr Mapping Improvement
> ------------------------------
>
> Key: CONNECTORS-840
> URL: https://issues.apache.org/jira/browse/CONNECTORS-840
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Solr-4.x-component
> Affects Versions: ManifoldCF 1.4.1
> Reporter: Alessandro Benedetti
> Assignee: Karl Wright
> Priority: Minor
> Labels: field, mapping, request, solr, update
> Fix For: ManifoldCF 1.5
>
> Attachments: CONNECTORS-840.patch
>
>
> "When you configure a job to use a Solr-type output connection, the Solr
> connection type provides a tab called "Field Mapping". The purpose of this
> tab is to allow you to map metadata fields as fetched by the job's connection
> type to fields that Solr is set up to receive. This is necessary because the
> names of the metadata items are often determined by the repository, with no
> alignment to fields defined in the Solr schema. You may also suppress
> specific metadata items from being sent to the index using this tab.
> Add a new mapping by filling in the "source" with the name of the metadata
> item from the repository, and "target" as the name of the output field in
> Solr, and click the "Add" button. Leaving the "target" field blank will
> result in all metadata items of that name not being sent to Solr."
> In my opinion we should change the way a metadata field is suppressed.
> The most natural way is that we express only the mappings of the metadata
> fields we want to keep.
> All the missing params will not be sent to Solr.
> The improvement will be :
> - same interface with a boolean flag in addition, this flag will specify if
> the missing metadata fields not expressed should be sent to Solr with the
> original names or not sent at all.
> In this way if we want to keep 3/100 metadata fields, we don't have to write
> 100 mapping entries , 97 empty but simply 3 entries and activate the flag.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
