[ 
https://issues.apache.org/jira/browse/CONNECTORS-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956154#comment-13956154
 ] 

Karl Wright commented on CONNECTORS-914:
----------------------------------------

Hi Ahmet,

Looking at your patch, I noted one issue at least:

+    <dependency>
+      <groupId>org.mortbay.jetty</groupId>
+      <artifactId>jetty</artifactId>
+      <version>${jetty.version}</version>
+    </dependency>

I think this should have scope "test", don't you?



> switch to maven build for solr3x plugin
> ---------------------------------------
>
>                 Key: CONNECTORS-914
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-914
>             Project: ManifoldCF
>          Issue Type: Task
>          Components: Solr-3.x-component, Solr-4.x-component
>    Affects Versions: ManifoldCF 1.5.1
>         Environment: Mac OS X 10.7.5
> java version "1.7.0_45"
> Apache Maven 3.0.3
> Apache Ant(TM) version 1.8.2 
>            Reporter: Ahmet Arslan
>            Assignee: Ahmet Arslan
>              Labels: maven, solr
>             Fix For: ManifoldCF 1.7
>
>         Attachments: CONNECTORS-914.patch
>
>
> Current ant build downloads solr distribution which is not required.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to