[
https://issues.apache.org/jira/browse/CONNECTORS-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342546#comment-14342546
]
Karl Wright commented on CONNECTORS-1160:
-----------------------------------------
I'm looking at the patch now, and I note that there have been a number of
formatting changes that seem unrelated to actual functional change, and are in
fact not consistent with Apache rules. For example:
{code}
@@ -295,14 +303,14 @@
Throwable thr = exception;
if (thr != null)
{
- if (thr instanceof RuntimeException)
- throw (RuntimeException)thr;
- else if (thr instanceof ManifoldCFException)
- throw (ManifoldCFException)thr;
- else if (thr instanceof Error)
- throw (Error)thr;
- else
- throw new RuntimeException("Unrecognized exception type:
"+thr.getClass().getName()+": "+thr.getMessage(),thr);
+ if (thr instanceof RuntimeException)
+ throw (RuntimeException)thr;
+ else if (thr instanceof ManifoldCFException)
+ throw (ManifoldCFException)thr;
+ else if (thr instanceof Error)
+ throw (Error)thr;
+ else
+ throw new RuntimeException("Unrecognized exception type:
"+thr.getClass().getName()+": "+thr.getMessage(),thr);
}
}
{code}
Formatting rules for this project are: 2 spaces per indent level, no tabs.
Would it be possible to fix the patch so that the formatting changes were
removed?
Thanks!
> Update Livelink Connector HTML String to Velocity Template
> ----------------------------------------------------------
>
> Key: CONNECTORS-1160
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1160
> Project: ManifoldCF
> Issue Type: Improvement
> Components: LiveLink connector
> Affects Versions: ManifoldCF 2.0.1
> Reporter: Kishore Kumar
> Assignee: Karl Wright
> Priority: Minor
> Labels: connector, patch, velocity
> Fix For: ManifoldCF 2.1
>
> Attachments: CONNECTORS-1160.patch
>
> Original Estimate: 672h
> Remaining Estimate: 672h
>
> Hi [[email protected]]
> I would like to contribute to Livelink connector by replacing all stringified
> html into velocity templates, if you think that is possible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
