> -----Original Message----- > From: Jason van Zyl [mailto:[EMAIL PROTECTED] > Sent: Saturday, July 05, 2003 11:52 PM > To: Maven Developers List > Subject: RE: [war plugin] - Proposition by default include instead > ofexclude > > > On Sat, 2003-07-05 at 17:24, Michal Maczka wrote: > > > -----Original Message----- > > > From: Vincent Massol [mailto:[EMAIL PROTECTED] > > > Sent: Saturday, July 05, 2003 10:57 PM > > > To: 'Maven Developers List' > > > Subject: RE: [war plugin] - Proposition by default include > > > instead of exclude > > > > > > > > > I think I'm -1 for making this change now. As you say there > are just too > > > many who are using it the other way. > > > > > But from the other hand - such change will be never easier from this > > perspective > > and there are much more "painful" changes coming (e.g. naming schema of > > plugins' properties) > > I think that we have a right to change things even drastically > while maven > > in still in beta stage. > > I think you should look at how you specify what you want in the WAR, I > think having properties within dependencies that affect the way plugins > work is not very good. I would say leave the current way as it is and > look for a better solution. Try to determine how you could isolate what > you want bundled, or more generally how to specify properties for > plugins. > > I have started cleaning up some of the plugin property access and marked > them as requirements for 1.0. You might want to do the same with plugin > properties that are defined in the POM. I think the war.bundle thing is > fairly bad as it started a bad trend of looking for hints in the > dependencies themselves. >
I agree. The best strategy will be to make something in the spirit of what we discussed some time ago I mean e.g. somehow distinguish between "runtime", "test" "compile" deps So say in case of war plugin all "runtime" dependencies should be bundled. And no special (plugin specific) way of marking will be needed. I will leave this subject until we will define what those terms mean and how we will denote them. As I am afraid that once we will progress in this field ...changes will be needed anyway. This case has also other background. We are discussing about changes in peripheral plugin (for sure maven-war-plugin is not a core plugin) and we are associating changes in this plugin with release of entire maven. For the moment I agree with Vincent that as long as do this and we are releasing this plugin along with maven core (or maven as a "whole") and we have no means to define dependencies on particular version of plugin, we should keep it backward compatible. Michal --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
