Henning, Please try the latest 2.14-SNAPSHOT version from the ASF repository. You should be able to just override the Checkstyle version by adding a dependency on Checkstyle 6.2 to the Maven Checkstyle Plugin in your project's POM.
On Sat, Jan 17, 2015 at 6:39 PM, Henning Schmiedehausen <henn...@schmiedehausen.org> wrote: > As long as I can just drop in 6.2 and the plugin does not break (as it > does today), I am fine. > > We are running our own checkstyle ruleset anyway, it is just the > default that does not work well. > > Where are your changes, I haven't seen them on the trunk @ github. > > -h > > > On Sat, Jan 17, 2015 at 9:30 AM, Hervé BOUTEMY <herve.bout...@free.fr> wrote: >> yes, i know you did that in the branch to test upgrade for a release with >> Checkstyle 6.2 as default version >> >> I did it in trunk, even without changing Checkstyle version: even if maven- >> checkstyle-plugin ships with an older Checkstyle version as default >> dependency, end-users can now upgrade the dependency when using the plugin >> >> Regards, >> >> Hervé >> >> >> Le samedi 17 janvier 2015 09:17:08 Henning Schmiedehausen a écrit : >>> I already did that. See https://github.com/apache/maven-plugins/pull/42 >>> >>> -h >>> >>> On Sat, Jan 17, 2015 at 9:02 AM, Hervé BOUTEMY <herve.bout...@free.fr> >> wrote: >>> > Le mercredi 14 janvier 2015 11:08:40 Henning Schmiedehausen a écrit : >>> >> The 6.2 checkstyle requires java 7 and it also removes (!) at least >>> >> one of the checks (RedundantThrows) which is used in all shipped >>> >> checkstyle sets and one of the integration tests. So you can no longer >>> >> use any of the builtin styles but have to use a custom style which has >>> >> the RedundantThrows check removed. >>> > >>> > the RedundantThrows check causes a lot of false positives: it is maked as >>> > "ingore" in Maven parent pom >>> > I'll remove it from default configs for next release: see MCHECKSTYLE-276 >>> > >>> >> Having code that can dynamically discover whether a given check exists >>> >> or not and change the configuration accordingly is something that >>> >> probably would need to be done inside checkstyle proper, not the >>> >> plugin driving it. >>> >> >>> >> I have a pull request prepared (not pushed yet) which would upgrade >>> >> checkstyle and the build to java 7 for a possible 2.16 release. One of >>> >> the problems here is that at least one integration test will not pass >>> >> until the patch was applied to trunk (because it remote-loads the rule >>> >> set from the svn repo which in turn currently still has the bad rule). >>> >> >>> >> It is all a mess and prolonging it to accomodate the one hold-out on >>> >> Java 5 (which is EOLed for > 5 years now) and the few that insist on >>> >> using Java 6 (which is EOLed for ~ 2 years) makes no sense to me. We >>> >> should lead, not lag behind. >>> >> >>> >> -h >>> >> >>> >> On Tue, Jan 13, 2015 at 11:09 PM, Hervé BOUTEMY <herve.bout...@free.fr> >>> > >>> > wrote: >>> >> > question: is upgrading only a question of changing dependency version? >>> >> > or >>> >> > does it require code change? >>> >> > and if it requires code change, can we do it with reasonable reflection >>> >> > or >>> >> > is it really too much change? >>> >> > >>> >> > because if we can let the end user upgrade his config (and better >>> >> > document), we would get the best of every choice >>> >> > >>> >> > Regards, >>> >> > >>> >> > Hervé >>> >> > >>> >> > Le mardi 13 janvier 2015 19:52:35 Henning Schmiedehausen a écrit : >>> >> >> I would pretty much abandon anything pre-Java 6 at this point and >>> >> >> start moving towards Java 7 soon. The checkstyle plugin right now has >>> >> >> three open releases with only the third being really useful ("upgrade >>> >> >> to latest checkstyle") and given the previous release cadence it makes >>> >> >> me fear that this release will not show before Mid-2015. >>> >> >> >>> >> >> -h >>> >> >> >>> >> >> On Fri, Jan 9, 2015 at 4:29 AM, Dennis Lundberg <denn...@apache.org> >>> > >>> > wrote: >>> >> >> > I've started going through the open issues and have found a problem >>> >> >> > that I need som help with. It turns out that Checkstyle 5.9 uses >>> >> >> > Java >>> >> >> > 6 classes, even though it is not mentioned in the release notes. How >>> >> >> > do we want to handle this? I see two possible options: >>> >> >> > >>> >> >> > 1. Make version 2.14 of the plugin require Java 6, and update it to >>> >> >> > use the latest available version of Checkstyle that runs on Java 6. >>> >> >> > >>> >> >> > 2. Revert the plugin back to Checkstyle 5.8 and release 2.14 of the >>> >> >> > plugin with a Java 5 requirement. After that release 2.15 of the >>> >> >> > plugin fairly straight away with a Java 6 requirement, and using the >>> >> >> > latest available version of Checkstyle that runs on Java 6. It >>> >> >> > should >>> >> >> > be noted that Checkstyle 5.8 does NOT work on Java 8 source code. >>> >> >> > >>> >> >> > Perhaps there are other alternatives? What do you think? >>> >> >> > >>> >> >> > On Thu, Jan 8, 2015 at 3:51 PM, Dennis Lundberg <denn...@apache.org> >>> >> > >>> >> > wrote: >>> >> >> >> Hi, >>> >> >> >> >>> >> >> >> I'd like to release version 2.14 of Maven Checkstyle Plugin. The >>> >> >> >> main >>> >> >> >> motive for 2.14 is the ability to check Java 8 source code. >>> >> >> >> >>> >> >> >> According to the road map there are 5 unresolved issues scheduled >>> >> >> >> for >>> >> >> >> 2.14. >>> >> >> >> >>> >> >> >> https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlass >>> >> >> >> ian >>> >> >> >> .ji >>> >> >> >> ra.plugin.system.project%3Aroadmap-panel >>> >> >> >> >>> >> >> >> If anyone is interested in fixing one or more of these for 2.14 now >>> >> >> >> would be a good time to do it. Just reply here with an estimated >>> >> >> >> time >>> >> >> >> frame. If noone has the time for this now, I'll reschedule those >>> >> >> >> issues for 2.15, which will require Java 6. >>> >> >> >> >>> >> >> >> -- >>> >> >> >> Dennis Lundberg >>> >> >> > >>> >> >> > -- >>> >> >> > Dennis Lundberg >>> >> >> > >>> >> >> > -------------------------------------------------------------------- >>> >> >> > - >>> >> >> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>> >> >> > For additional commands, e-mail: dev-h...@maven.apache.org >>> >> >> >>> >> >> --------------------------------------------------------------------- >>> >> >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>> >> >> For additional commands, e-mail: dev-h...@maven.apache.org >>> >> > >>> >> > --------------------------------------------------------------------- >>> >> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>> >> > For additional commands, e-mail: dev-h...@maven.apache.org >>> >> >>> >> --------------------------------------------------------------------- >>> >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>> >> For additional commands, e-mail: dev-h...@maven.apache.org >>> > >>> > --------------------------------------------------------------------- >>> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>> > For additional commands, e-mail: dev-h...@maven.apache.org >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>> For additional commands, e-mail: dev-h...@maven.apache.org >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > -- Dennis Lundberg --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
