On June 2, 2016 at 3:15:35 PM, Hervé BOUTEMY (herve.bout...@free.fr) wrote: I merged the PR in the slf4j-gossip branch (and added a little improvement)
core ITs are ok (notice: ran without activating colors) The testsuite certainly will not be very happy with color enabled as many tests are expecting exact strings in the output. I had considered setting MAVEN_SKIP_RC env-var to avoid any local customization from polluting the testsuite execution. colors for Linux are not exactly the same as the screen dump: yellow from the screen dump is bold white on Linux. This is ok for me Terminals can render whatever colors they want for the ANSI colors and many have this configurable. Now, what's annoying is that: - color is not enabled by default: I had to configure MAVEN_OPTS="- Dmaven.logging=color" Seemed safer off by default then breaking the output for users where ansi is not supported and for whatever reason its not been detected as such to strip out. - when redirecting content to file, color is not disabled automatically It may depend on how its redirected, my local testing shows that `mvn > foo’ disables ansi sequences, though I can not say I’ve done any exhaustive testing of this. To be able to tell if System.out is an ANSI-aware terminal it may need a bit more love ala jline or more helpers in jansi to do more properly? —jason
