Hi Hervé, would it be possible to enhance this with such features:
1. make colors configurables through a user config (~/.m2/settings.xml? or colors.xml) 2. make color config regex friendly. The idea is to be able to get a coloration like https://github.com/rmannibucau/maven-color which depends what is shown and not only the level ? Anyway thanks for moving forward this feature expected for too long by a LOT of users! Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber <http://www.tomitribe.com> | JavaEE Factory <https://javaeefactory-rmannibucau.rhcloud.com> 2016-06-06 8:26 GMT+02:00 Hervé BOUTEMY <herve.bout...@free.fr>: > Hi, > > As you may have noticed, I created a MNG-3507 branch. > The idea here is to develop colorization not at slf4j implementation level, > but in core (and later plugins): slf4j implementation is only responsible > for > DEBUG/INFO/WARNING/ERROR colorization, core and plugins are responsible for > messages. > > I implemented message colorization that J Dillon did in slf4j-gossip: the > only > part I still didn't do is the stacktrace enhancement. > Batch mode disables color: we can choose to create specific CLI options > later > if we prefer. > And the most important is that core provides jansi to plugins: any plugin > using jansi benefits from jansi configuration (mainly enable/disable color) > > As a proof of concept, I implemented color output in core ITs invoker [1]: > if > run with older Maven, color is always on (since core doesn't provide > configured jansi), but if run with the branch, the plugin has color > deactivated in batch mode. > As you can see, also, Jenkins doesn't display ansi code nicely [2]... > > I also updated some IT test code to strip ansi codes [3] and not choke with > color on. > > I still need to test on Windows, if nobody beats me at it. > > If nobody objects, I'll merge code to master and update slf4j-gossip > accordingly (a lot of features are now in core): the discussion on changing > default slf4j implementation will happen a little bit later. > > Regards, > > Hervé > > > [1] > http://git-wip-us.apache.org/repos/asf/maven-integration-testing/commit/13bd5416 > > [2] > https://builds.apache.org/view/M-R/view/Maven/job/core-integration-testing-maven-3-embedded/7280/console > > [3] http://svn.apache.org/r1746888 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
