Hi,
On 27/11/16 18:34, Hervé BOUTEMY wrote:
yes, reverting MRESOURCES-223 seems reasonable since it has drawbacks that
were not envisioned IMHO
Yes this is a problem...
So this should be changed...I think of introducing an option to simply
disable escaping...which will keep the behaviour of current 3.X line but
gives the freedom to change it if needed...like deactivate escaping in
some situations...
Or reverting the change will also be an option...
The idea was having a default value which was often used which
unfortunately has the drawback of not being simply to be disabled...the
solution "∅" looks hacky ;-( ...so I would introduce an option to
disable escaping...
Kind regards
Karl Heinz
Karl Heinz, since you worked on MRESOURCES-223, what do you think about it?
Regards,
Hervé
Le vendredi 25 novembre 2016, 14:24:15 CET Christian Schulte a écrit :
Hi,
the maven-resources-plugin has enabled escaping by default in version
3.0.0 - see MRESOURCES-223 [1]. Prior to version 3.0.0, users wanting to
make use of any escaping needed to set the 'escapeString' parameter to
some value. This parameter starts to default to the backslash as of
version 3.0.0. This has led to various issues. MRESOURCES-230 [2] and
MRESOURCES-231 [3].
MRESOURCES-230: Can't escape the escape string
I created an issue against maven-filtering - MSHARED-599 [4]. There is a
testcase in maven filtering testing that the escape string does not get
escaped. There is no way to allow escaping the escape string without
updating that test case. Starting to escape the escape string
potentionally breaks filtering resources relying on '\\' (two
backslashes) to be preserved after filtering. In practice, if we "fix"
maven-filtering to support escaping the escape string, properties
resources and any resources using backshlashes themselves for escaping,
will be broken after filtering. That means - there is no way to fix
MRESOURCES-230 [2] and MSHARED-599 [4] without introducing issues
mentioned above.
MRESOURCES-231: Can't disable escaping
Solution to this is to set the 'escapeString' parameter to ∅ to
disable escaping. That means every user upgrading from a
maven-resources-plugin version < 3.0.0 will need to disable escaping, to
get the plugin behave the same way it did before. Users having used
escaping before, will have set the 'escapeString' parameter, so will not
notice anything.
I would like to make a release of the maven-resources-plugin (3.1.0 or
3.0.2?) and make the 'escapeString' parameter default to 'null' again.
WDYT? Users upgrading from < 3.0.0 to > 3.0.1 will not need to do
anything. If they have been using escaping before, they will have set
that parameter already, if they have not been using escaping before,
they will not need to do anything as escaping will no longer be enabled
by default due to the upgrade.
[1] <https://issues.apache.org/jira/browse/MRESOURCES-223>
[2] <https://issues.apache.org/jira/browse/MRESOURCES-230>
[3] <https://issues.apache.org/jira/browse/MRESOURCES-231>
[4] <https://issues.apache.org/jira/browse/MSHARED-599>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
