Merged On 13 January 2017 at 13:43, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote:
> https://github.com/apache/maven-integration-testing/commit/ > 6c86dc6fe8bad24950fa76d295910e7d7e145a21 is the diff I am proposing > (we'll know in 2 hours if it worked on a full test run) > > On 13 January 2017 at 13:28, Stephen Connolly < > stephen.alan.conno...@gmail.com> wrote: > >> https://builds.apache.org/job/maven-jenkinsfile/job/mng-6155/6/ is a >> full build run with my proposed fix to MNG-6155 >> >> On 13 January 2017 at 13:25, Stephen Connolly < >> stephen.alan.conno...@gmail.com> wrote: >> >>> Yep... looks like that's the real fix >>> >>> On 13 January 2017 at 11:25, Stephen Connolly < >>> stephen.alan.conno...@gmail.com> wrote: >>> >>>> I have 5 builds stacked up with https://github.com/apache >>>> /maven-integration-testing/commit/1013b7d6bf25e831860276ae68 >>>> e226134481cbb3 if >>>> >>>> <settings> >>>> <mirrors> >>>> <mirror> >>>> - <id>test-mirror</id> >>>> + <id>central</id> >>>> <url>@protocol@://www.example.com/</url> >>>> <mirrorOf>*</mirrorOf> >>>> </mirror> >>>> >>>> works for all 5 builds then I will rebase to remove the narrowing of >>>> the tests to just one integration test and we can see if that runs on the >>>> full cycle and then merge and be done with MNG-6155 >>>> >>>> On 13 January 2017 at 11:07, Stephen Connolly < >>>> stephen.alan.conno...@gmail.com> wrote: >>>> >>>>> https://builds.apache.org/job/maven-jenkinsfile/job/mng-6155/ (which >>>>> is just running the affected test) >>>>> >>>>> On 13 January 2017 at 11:03, Stephen Connolly < >>>>> stephen.alan.conno...@gmail.com> wrote: >>>>> >>>>>> So the problem here AIUI is that we keep metadata about when we last >>>>>> checked the local repository against the remote. >>>>>> >>>>>> When you are using dav as the proxy protocol, we need the webdav >>>>>> extension in order to check that the local repository artifacts match the >>>>>> remote... but we have not checked the webdav extension itself... so >>>>>> without >>>>>> -llr maven tries to check the content for validity *before* it has >>>>>> enabled >>>>>> the extension and consequently there is no dav protocol and it cannot >>>>>> check >>>>>> >>>>>> with -llr we skip the checking of the content against the remote. >>>>>> >>>>>> If we ran the test in off-line mode then we would also skip the >>>>>> test... but we cannot do that as the whole point of the test is to run in >>>>>> on-line mode >>>>>> >>>>>> What we really want to do is run a dummy project first with no proxy >>>>>> but enabling the webdav extension (that will create the markers) *and >>>>>> then* >>>>>> we can run the real project. >>>>>> >>>>>> I wonder if the issue is that we have a different id on the mirror: >>>>>> >>>>>> https://github.com/apache/maven-integration-testing/blob/mas >>>>>> ter/core-it-suite/src/test/resources/mng-3599-mk2/settings-t >>>>>> emplate.xml#L4 >>>>>> >>>>>> vs >>>>>> >>>>>> https://github.com/apache/maven-integration-testing/blob/mas >>>>>> ter/core-it-suite/src/test/resources-filtered/settings.xml#L34 >>>>>> >>>>>> If we gave the mirror the id of "central" could we remove llr? >>>>>> >>>>>> I shall take a test to see! >>>>>> >>>>>> On 13 January 2017 at 10:34, Robert Scholte <rfscho...@apache.org> >>>>>> wrote: >>>>>> >>>>>>> Just to be sure: >>>>>>> MNG-3599 is about "webdav does not set http-proxy correctly" >>>>>>> -llr (or --legacy-local-repository) introduced by MNG-5181 is about >>>>>>> skipping some checks done when working with the default local >>>>>>> repository. >>>>>>> I don't see any relationship, in which case the test adjustment is >>>>>>> fine for now. >>>>>>> However, it would still be better if we didn't need this flag. >>>>>>> >>>>>>> Robert >>>>>>> >>>>>>> >>>>>>> On Thu, 12 Jan 2017 01:32:36 +0100, Stephen Connolly < >>>>>>> stephen.alan.conno...@gmail.com> wrote: >>>>>>> >>>>>>> Well now after several repeats still no sign of the failure when >>>>>>>> running >>>>>>>> with -llr >>>>>>>> >>>>>>>> On Wed 11 Jan 2017 at 21:08, Christian Schulte <c...@schulte.it> >>>>>>>> wrote: >>>>>>>> >>>>>>>> Am 01/11/17 um 17:53 schrieb Stephen Connolly: >>>>>>>>> >>>>>>>>> > Yes... oh and --legacy-local-repository fixed the tests: >>>>>>>>> >>>>>>>>> > >>>>>>>>> https://builds.apache.org/job/maven-jenkinsfile/job/mng-3599 >>>>>>>>> /4/testReport/ >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Can you re-run the test on windows multiple times? The failure has >>>>>>>>> not >>>>>>>>> >>>>>>>>> been reproducible so far. It succeeds a couple of times, then >>>>>>>>> fails a >>>>>>>>> >>>>>>>>> couple of times, then succeeds again without anything having >>>>>>>>> changed. >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> ------------------------------------------------------------ >>>>>>>>> --------- >>>>>>>>> >>>>>>>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>>>>>>>> >>>>>>>>> For additional commands, e-mail: dev-h...@maven.apache.org >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> >>>>>>>> Sent from my phone >>>>>>>> >>>>>>> >>>>>>> ------------------------------------------------------------ >>>>>>> --------- >>>>>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>>>>>> For additional commands, e-mail: dev-h...@maven.apache.org >>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >> >
