I am concerned that there are some quoting issues in mvn.
In some cases we use var=`command` and in others we use var="`command`"
Additionally we have a mixture of backtick and $(...) style. My
understanding is that the backticks are for older shells...
but if that is the case we should use backticks consistently
line 64: saveddir=`pwd`
should be? saveddir="`pwd`"
line 66: MAVEN_HOME=`dirname "$PRG"`/..
should be? MAVEN_HOME="`dirname "$PRG"`/.."
line 69: MAVEN_HOME=`cd "$MAVEN_HOME" && pwd`
should be? MAVEN_HOME="`cd "$MAVEN_HOME" && pwd`"
line 105: CLASSWORLDS_JAR=`echo
"${MAVEN_HOME}"/boot/plexus-classworlds-*.jar`
should be? CLASSWORLDS_JAR="`echo
"${MAVEN_HOME}"/boot/plexus-classworlds-*.jar`"
line 128: basedir=$wdir
should be? basedir="$wdir"
line 145: basedir=$(dirname "$(readlink -f "${arg}")")
should be? basedir="$(dirname "$(readlink -f "${arg}")")"
(or perhaps) basedir="$(cd "$(dirname "${arg}")" && pwd -P)"
line 178: MAVEN_PROJECTBASEDIR=`cygpath --path --windows
"$MAVEN_PROJECTBASEDIR"`
should be? MAVEN_PROJECTBASEDIR="`cygpath --path --windows
"$MAVEN_PROJECTBASEDIR"`"
/me got tired looking at the file after this point in time!
On 24 March 2017 at 21:07, Christian Schulte <[email protected]> wrote:
> Am 03/24/17 um 11:45 schrieb Stephen Connolly:
> > https://issues.apache.org/jira/issues/?jql=project%20%
> 3D%20MNG%20AND%20fixVersion%20%3D%203.5.0-candidate%20AND%
> 20resolution%20%3D%20Unresolved%20ORDER%20BY%20due%20ASC%2C%20priority%
> 20DESC%2C%20created%20ASC
> >
> > Here is my opinions:
> >
> > https://issues.apache.org/jira/browse/MNG-6168 - If this is available
> and
> > ready quickly (i.e. in the next week), we can review the changes and
> assess
> > the risk
>
> Branch is here:
> <https://git-wip-us.apache.org/repos/asf?p=maven.git;a=
> shortlog;h=refs/heads/MNG-6168>
>
> Commit is here:
> <https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commitdiff;h=
> 0931bb2cc7630cc79adb98407db13315b4a709ee>
>
> Will merge to master, as soon as the build job succeeds. It's just
> updates to use the try-with-resources statement instead of
> try-catch-finally with IOUtil.close.
>
> Regards,
> --
> Christian
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>
