IMHO every guideline should have a small explanation (and maybe less aggressive)
A suggestion:

No tabs! Please use spaces for indentation.

The Maven Codestyle uses spaces instead of spaces. This way column numbers don't depend on the IDE settings and will be the same for everyone.

Respect the [code style][code-style].

By using the same codestyle, patches should only highlight the actual difference, not being disturbed by any formatting issues.

thanks,
Robert

On Mon, 19 Feb 2018 19:59:26 +0100, Karl Heinz Marbaise <khmarba...@gmx.de> wrote:

Hi,

I would like to integrate the issue MNG-6362 which contains only enhancements for the README.md, CONTRIBUTION.md and a pull_request_template.md (No code changes)..

It's intended to improve the experience for GitHub users..

You can take a look how it currently looks like via the following links:

https://github.com/apache/maven/blob/MNG-6362/.github/pull_request_template.md
https://github.com/apache/maven/blob/MNG-6362/CONTRIBUTING.md
https://github.com/apache/maven/tree/MNG-6362


If you have suggestions for enhancements/fixes etc.

Please come up with it....

Kind regards
Karl Heinz Marbaise

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to