Am 2019-10-06 um 20:35 schrieb Hervé BOUTEMY:
Le dimanche 6 octobre 2019 20:29:46 CEST, vous avez écrit :
Am 2019-10-06 um 20:21 schrieb Hervé BOUTEMY:> Le dimanche 6 octobre
2019 12:24:57 CEST, vous avez écrit :
>> Am 2019-10-06 um 09:35 schrieb Hervé BOUTEMY:
>>> Le samedi 5 octobre 2019, 22:46:20 CEST Michael Osipov a écrit :
>>>> Am 2019-10-05 um 22:10 schrieb Hervé BOUTEMY:
>>>>> Le samedi 5 octobre 2019 20:41:40 CEST, vous avez écrit :
>>>>>> Am 2019-10-05 um 19:52 schrieb Hervé BOUTEMY:
>>>>>>> based on the feedback I got, I updated the proposal:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74682
>>>>>>> 31
>>>>>>> 8
>>>>>>>
>>>>>>> The archives entries timestamp is now configured with
>>>>>>> project.build.outputTimestamp property, in ISO-8601 format
<project>
>>>>>>> <properties>
<project.build.outputTimestamp>2019-10-02T08:04:00Z</project.bu
>>>>>>> ild
>>>>>>> .ou
>>>>>>> tputTimestamp>>
>>>>>>>
>>>>>>> </properties>
>>>>>>>
>>>>>>> </project>
>>>>>>>
>>>>>>> The shared components, plugins, parent poms and Maven core branches
>>>>>>> have
>>>>>>> been updated to match this new proposal
>>>>>>>
>>>>>>>
>>>>>>> If no one objects, next week-end, I'll start the (heavy)
release train
>>>>>>> to
>>>>>>> bring (binary) Reproducible Builds plugins to general availability
>>>>>>
>>>>>> Really, really nice work..
>>>>>
>>>>> thank you, it required a lot of energy for a long period of time...
>>>>>
>>>>>> I do like <project.build.outputTimestamp>. Why did you make it a
>>>>>> String?
>>>>>> Why not go directly with Instant? It gives your ISO 8601 for free
>>>>>
>>>>> I tried to explain it in
>>>>> https://issues.apache.org/jira/browse/MSHARED-837
>>>>> Plexus Date injection support is really limited: could not match the
>>>>> requirements
>>>>
>>>> yyyy-MM-dd'T'HH:mm:ssXXX and SimpleDateFormat will do the trick.
It also
>>>> will require to change the converter of course.
>>>>
>>>> Alternatively, you could try
https://commons.apache.org/proper/commons-lang/javadocs/api-release/src-h
>>>> tml /org/apache/commons/lang3/time/DateFormatUtils.html#line.72
which I
>>>> have added long time ago.
>>>
>>> the question is not about coding the date format: it's already done in
>>> maven-archiver
https://github.com/apache/maven-archiver/commit/5f07f227aa89e0bb4163c125a
>>> 46fbd4c78445301
>>
>> The commit contains some flaws. I will leave comments there.
>>
>>> the question, as you perfectly asked initially, is: do you have an
idea on
>>> how to have the direct Date injection, instead of having a String
in the
>>> plugin parameter?
>>
>> I assumed the DateConverter will do as soon as you say:
>> @Parameter
>> Date myDate;
>>
>> Won't it?
>
> yes, it will
> and if you look at the SimpleDateFormat value, you'll see that it
does not
> permit any timezone, then uses the local developper timezone, then is not
> reproducible
No, it won't if you supply and enforce XXX => yyyy-MM-dd'T'HH:mm:ssXXX.
The input has to have the tz offset, thus you'll have it properly
converted. It would perform the very same conversion and your code
currently does in Maven Archiver. You should give it a try.
DateConverter is part of plexus-containers and Sisu: I'm not modifying them
Why don't you say some upfront? I assumed you want to change it.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
