Il Mar 14 Lug 2020, 13:09 Elliotte Rusty Harold <elh...@ibiblio.org> ha scritto:
> On Tue, Jul 14, 2020 at 2:25 AM Olivier Lamy <ol...@apache.org> wrote: > > > > > ***DO NOT CREATE PULL REQUEST FOR RIDICULOUS COMMIT WHICH DO NOT NEED > REVIEW*** > > IMHO all PRs need review for the same reason everything needs a test. > I see your pain. Having reviews by fellow committers and from the community helps a lot. I felt this way the first times I got write permission to Maven repositories. But we have many repositories and those simple pull requests really sound as noise. Every commit you push to a shared repository triggers an email and every other committer (and anyone who is subscribe to the ml) sees your commit and can chime in in case there is something wrong. So feel free to commit simple stuff as far as you stay into our conventions and integration tests pass. We are all here and see the flow of commits. Feel free to ask for review, in that case I prefer a PR. I hope that helps Enrico >From experience I know I can't tell the difference between PRs that > are too simple to fail and PRs that only look that way. > > > it's very noisy and useless notifications (especially because we get > from both gitbox and github....) > > Not sure why you're seeing all these notifications. I don't see them. > Probably because you are the author However if both gitbox and github are sending notices for the same PR, > there's a really easy fix. Simply disable one of the two from sending > any notifications. > > -- > Elliotte Rusty Harold > elh...@ibiblio.org > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
