mthmulders commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553965389
########## File path: content/apt/guides/introduction/introduction-to-profiles.apt ########## @@ -100,9 +100,11 @@ Introduction to Build Profiles profile IDs to use. The profile(s) specified in the option are activated in addition to any profiles which are activated by their activation configuration or the <<<\<activeProfiles\>>>> section in <<<settings.xml>>>. + Maven will refuse to activate or deactivate a profile that cannot be resolved. + To prevent this, prefix the profile identifier with an <<<?>>>, marking it as optional: Review comment: Makes sense, updated. ########## File path: content/apt/guides/introduction/introduction-to-profiles.apt ########## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test identifier with either the character '!' or '-' as shown below: +---+ -mvn groupId:artifactId:goal -P !profile-1,!profile-2 +mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3 Review comment: Should be `mvn -N validate -P \!profile-1,\!profile-2`, but I think it depends on the shell you use. For now, I followed the existing guide... ########## File path: content/apt/guides/introduction/introduction-to-profiles.apt ########## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test identifier with either the character '!' or '-' as shown below: +---+ -mvn groupId:artifactId:goal -P !profile-1,!profile-2 +mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3 Review comment: > Then you might be affected by something like MNG-7011. Correct - although that is not something that is introduced by [MNG-7051](https://issues.apache.org/jira/browse/MNG-7051). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org