michael-o commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r553996067
##########
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##########
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
identifier with either the character '!' or '-' as shown below:
+---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3
Review comment:
Correct the ! can be disabled in bash and is a bash problem, not ours.
##########
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##########
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
identifier with either the character '!' or '-' as shown below:
+---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3
Review comment:
How do I interprete `!?`? Is it the same as `?!`?
##########
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##########
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
identifier with either the character '!' or '-' as shown below:
+---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3
Review comment:
Alright. Keep one consistent option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
