hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980644191
thinking at default type more in depth, I think that I now understand the logic = making `script` the default is not sufficient, because if `.mvn/wrapper/maven-wrapper.jar` or `*.jar` is not in `.gitignore`, the jar will inevitably come into future Git commit then the logic is to have `bin` by default when installing maven-wrapper, and the `.gitignore` configuration will trigger if the jar is stored or not (and if not stored, the consequence in network access) thinking like this, I now feel that yes, `bin` should be default... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
