hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-983710755
> The choice for `script` was because in general we don't want binaries in the SCM. There's no real damage if the file is committed anyway. making script the default is not sufficient, because if .mvn/wrapper/maven-wrapper.jar or *.jar is not in .gitignore, the jar will inevitably come into future Git commit, not by the guy who did `mvn wrapper:wrapper`, by the user who will do `./mvnw` and commit everything without remarking that `wrapper.jar` was downloaded then forcing `mvn wrapper:wrapper` not to download `maven-wrapper.jar` just adds an additional friction (= `mvnw` needs to be able to download the jar, without the help of Maven settings) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
