I created issues with the proposition of improvement: https://issues.apache.org/jira/browse/MWRAPPER-31 https://issues.apache.org/jira/browse/MWRAPPER-32 https://issues.apache.org/jira/browse/MWRAPPER-33
please assign a version to fix ... if it is applicable. śr., 8 gru 2021 o 19:47 Hervé BOUTEMY <herve.bout...@free.fr> napisał(a): > because it's as it was imported: > https://github.com/takari/maven-wrapper/blob/master/pom.xml#L21 > I refactored but kept everything as equivalent as possible > > we can update the value if it has an interest, with associated Jira issue > > Regards, > > Hervé > > Le mercredi 8 décembre 2021, 19:14:55 CET Slawomir Jaranowski a écrit : > > Next question: > > > > - why use java 5 in maven-wrapper module .. it is not possible build > with > > java > 8 [1] > > > > [1] > > > https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-wrapper/job/ma > > ster/ > > śr., 8 gru 2021 o 19:05 Hervé BOUTEMY <herve.bout...@free.fr> > napisał(a): > > > Le mercredi 8 décembre 2021, 15:52:46 CET Robert Scholte a écrit : > > > > With mvn verify -Prun-its all ITs fail on my system. This should work > > > > out-of-the-box, so I'll need to investigate the issue. > > > > > > > > And I'm pretty sure we can remove the cli package: you can't pass > System > > > > properties to Maven, only arguments. And they should be passed as is > to > > > > mvn. > > > > > > I must admit I don't know: I suppose that if the code is here from the > > > beginning, it's for some use, it's just me who did not imagine the use > > > case > > > > > > if everybody is confident that it's never used, no problem to remove it > > > > > > > IT's should confirm that. > > > > > > > > Robert > > > > > > > > ------ Origineel bericht ------ > > > > Van: "Jason van Zyl" <ja...@vanzyl.ca> > > > > Aan: "Maven Developers List" <dev@maven.apache.org> > > > > Verzonden: 7-12-2021 14:55:32 > > > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > > > > > > >Everything builds and it generates the wrapper for a project in a > way > > > > > > will > > > > > > > >be familiar to existing users. The switch for current users should, > > > > >hopefully, be painless and transparent. > > > > > > > > > >Nice work Robert and Hervé. I put a notice on the GitHub page for > the > > > > >Takari version about the impending release at Apache, and provided > > > > >pointers to the new Git repository and JIRA project. > > > > > > > > > >jvz > > > > > > > > > >> On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY <herve.bout...@free.fr > > > > > > > > wrote: > > > > >> Hi, > > > > >> > > > > >> Maven Wrapper has been donated to Apache Maven, imported to > > > > >> > > > > >>https://github.com/apache/maven-wrapper > > > > >> > > > > >> Documentation published to https://maven.apache.org/wrapper/ > > > > > > > >> Here is the list of fixes from previous 0.5.6 release: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721& > > > > > > > >>version=12350068>> > > > > >> > > > > >> Please test and review so we can do a release soon > > > > >> > > > > >> Regards, > > > > >> > > > > >> Hervé > > > > >> > > > > >> > > > > >> > > > > >> > -------------------------------------------------------------------- > > > > >> - > > > > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > >--------------------------------------------------------------------- > > > > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > >For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Sławomir Jaranowski