marquiswang commented on code in PR #23:
URL:
https://github.com/apache/maven-shared-incremental/pull/23#discussion_r1173837700
##########
src/main/java/org/apache/maven/shared/incremental/IncrementalBuildHelper.java:
##########
@@ -129,6 +146,30 @@ public void setDirectoryScanner( DirectoryScanner
directoryScanner )
this.directoryScanner = directoryScanner;
}
+ /**
+ * Get the existing DirectoryScanner used by this helper,
+ * or create new a DirectoryScanner if none is yet set.
+ * The DirectoryScanner is used for detecting changes in a directory
+ */
+ public DirectoryScanner getGeneratedSourcesDirectoryScanner()
+ {
+ if ( generatedSourcesDirectoryScanner == null )
+ {
+ generatedSourcesDirectoryScanner = new DirectoryScanner();
+ }
+
+ return generatedSourcesDirectoryScanner;
+ }
+
+ /**
+ * Set the DirectoryScanner which shall get used by this build helper.
+ * @param generatedSourcesDirectoryScanner
+ */
+ public void setGeneratedSourcesDirectoryScanner( DirectoryScanner
generatedSourcesDirectoryScanner )
Review Comment:
But I agree entirely with you that this class seems pointless. But I have no
idea who uses it so it doesn't seem safe to change? Or would you prefer that I
delete/inline this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
