marquiswang commented on PR #23: URL: https://github.com/apache/maven-shared-incremental/pull/23#issuecomment-1517971645
> As it is separate component we need separate jira issue 😄 to correctly build a release notes. Should that still be MCOMPILER? > > I know that unit tests are missing here ... can you try add first one for your change? Uhhhhhhhh... I'm not sure it is practical for me to write the unit tests for this file. If you are able to whip together a quick one I can add one for this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org