Hi Mavens,

I was browsing through the dist plugin source code and I have a few
questions/remarks/proposal:

1/ Are the following properties used at all or can they be deleted: 
maven.dist.tar.executable=tar
maven.dist.gunzip.executable=gunzip

2/ Why is there a dependency to the jar:jar goal in the dist plugin? What if
I'm building a WAR? Wouldn't it be better if the dist does not call any
artifact building code at all (letting the user do it) or if the goal called
is pluggable? 

Note: This is also required if the artifact is built by a top level
multiproject goal (I have such a need in Cargo where I aggregate several
jars into a single big one).

I think we would need 2 properties:
- one for specifying a goal to call (the goal that generates the artifacts
to include in the distrib)
- one for specifying the locations of the generated artifacts. It would need
to be a list as a multiproject can generate several artifacts. We would
remove the existing "maven.dist.bin.artifact" property.

3/ Same question for the site: what if I'm building a multiproject and the
site goal is multiproject:site or a custom goal?

We would also need 2 properties:
- one for specifying the goal to call that generates the site
- one for specifying the generates doc directory (would default to
${maven.docs.dest})

4/ Could we add 2 properties:
- maven.dist.type.zip = true|false
- maven.dist.type.targz = true|false

They would both default to true.

Thanks
-Vincent


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to