[ http://jira.codehaus.org/browse/MNG-645?page=comments#action_43431 ]
Vincent Massol commented on MNG-645: ------------------------------------ Thanks Emmanuel but looking at the javadoc report shows that it extends AbstractMavenReport but overrides one of its main method (generate()) thus negating what it does. In addition site resources are still generated and you need to also override the execute() method to prevent that. I still believe the AbstractMavenReport currently doesn't support external reports. The best may be to have 2 abstract MavenReport implementations: - AbstractExternalMavenReport - AbstractMavenReport I don't think it's right to extend something to negate its effect by overriding its key methods. Sounds hackish to me ;-) > Allow for external reports > -------------------------- > > Key: MNG-645 > URL: http://jira.codehaus.org/browse/MNG-645 > Project: Maven 2 > Type: Task > Components: maven-reports > Versions: 2.0-alpha-3 > Reporter: Vincent Massol > Priority: Minor > > > Currently the AbstractMavenReport implementation has: > public void execute() > throws MojoExecutionException > { > try > { > String outputDirectory = getOutputDirectory(); > XhtmlSink sink = getSiteRenderer().createSink( new File( > outputDirectory ), getOutputName() + ".html", > outputDirectory, > getSiteDescriptor(), "maven" ); > [...] > This means that an HTML file with the report name will always be created. > However, for the Clover plugin the HTML files are generated by the Clover API > itself and we don't control them. Thus we don't need this clover.html file. > I believe the AbstractMavenReport class should support report mojos that have > externally generated HTML files too. > For now, I've implemented MavenReport instead of extending > AbstractMavenReport. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
