[ http://jira.codehaus.org/browse/MNG-760?page=comments#action_45209 ] 

Kenney Westerhof commented on MNG-760:
--------------------------------------

I'm sorry but I can't get this patch to apply, even when I downgraded to the 
revision specified in that dir.

Could you please svn up, fix merge conflicts if possible, and send me a new 
patch relative to the
maven-2 directory? The D:/... confuses diff; after stripping that it still 
didn't apply (problems with the svn properties,
removed those too but then kept getting errors).

Sorry I didn't see this issue before I started working on the plugin. I know 
what it feels like to keep merging
your local diff against an ever changing m2.. :)

> m2 eclipse plugin improvements (source download and attachment, customization 
> of natures/builders/conclasspath, flexible project dupport) and refactoring
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
>          Key: MNG-760
>          URL: http://jira.codehaus.org/browse/MNG-760
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Versions: 2.0-beta-1
>     Reporter: fabrizio giustina
>     Assignee: Kenney Westerhof
>      Fix For: 2.0-beta-1
>  Attachments: MNG-760-1.diff, MNG-760.diff
>
>
> This patch adds the following to the M2 eclipse plugin:
> - downloading of source attachments and configuration in .classpath
> - customization of project builders and natures in .project (like in the m1 
> plugin)
> - additional conclasspath entries in .classpath (like in the m1 plugin)
> - fix: don't add duplicate directories if main/resources directories overlap  
> (like in the m1 plugin)
> - support for flexible projects (.wtpmodules file generation for utility  
> modules, wars, ejbs)
> Along with these new features the plugin has been refactored, splitting the 
> single big EclipseWriter class to several specific classes and all the 
> messages have been externalized in a property file.
> There are still some todos in the code, which probably some M2 guru could 
> look at, but anyway all the existing functionalities continue to work and 
> some other tests have been added.
> Due to the refactoring the patch looks more like a complete rewrite: sorry 
> for that, but adding new features without splitting the existing file was ugly

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to