[ http://jira.codehaus.org/browse/MNG-1181?page=comments#action_59089 ]
Jochen Wiedmann commented on MNG-1181: -------------------------------------- > the embedder2 class seems to be missing some functionality of the original, > namely the reading of models and MavenProjects. Yes, that's true, and I already noted that. I see three possible solutions: - My personal favourite: Open the DefaultMaven class to provide this functionality. Possibly open it as protected methods only and make MavenEmbedder2 a subclass of DefaultMaven, which opens this. - Copy code from DefaultMaven, or MavenEmbedder. Personally, I do not like this, because copying code is bad. - Change the MavenEmbedders execute methods to work with or like the MavenEmbedder. I also do not like this, because it still leaves the problem of doing things different than the "raw Maven". > can you elaborate on if/how MNG-1665 will work with your embedder2? The test case attached to MNG-1181 doesn't check that. However, considering that the MavenEmbedder2 really does nothing different than the command line Maven, I see no reason to believe the it won't work. > MavenEmbedder.execute() doesn't run reactor modules > --------------------------------------------------- > > Key: MNG-1181 > URL: http://jira.codehaus.org/browse/MNG-1181 > Project: Maven 2 > Type: Bug > Components: Embedding > Reporter: Eugene Kuleshov > Priority: Blocker > Fix For: 2.0.4 > Attachments: MNG-1181.tar.gz, MavenEmbedder2.java > > > MavenEmbedder.execute() doesn't run reactor modules. > I've been trying to run it with "generate-sources" goal, but it only build > the root project. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
