On 18 Mar 07, at 5:52 PM 18 Mar 07, Brett Porter wrote:
-1 on this change.
I apologise - I was sure I responsed to your mail saying you were
going to do this yesterday saying that I objected, but it never
made it to the list.
I can't see any reason to remove these 2 modules from Doxia - I
believe Doxia should be capable of generating a fully decorated
site on it's own.
I think that should be relegated to another layer as explained below.
They are not presently coupled to Maven at all, and moving them
into a Maven site tools project obviously does.
The still won't be coupled to Maven they will be for generating
sites. They will not be coupled to Maven and in fact sitetools could
be a standard site toolkit.
What was your justification for removing them?
That Doxia is a content framework consisting of parsers, and sinks
and that's it. Small, with a clear purpose and very limited API.
Anything else can be layered on top of that. What's there now is very
small and easier managed without tangling concerns of books or sites.
So standard separation of concerns was my impetus. A small API for
Doxia, site capabilities in another layer, book capabilities in
another layer. The site and book functionality in Doxia are whole
different tool sets. If I make changes to the site, or book
capabilities I am then forced to release Doxia to publish those
changes. I see no downside in modularizing the site and book
functionality. Do they not seem to be separate concerns to you?
The whole point of our tooling mechanism to the transitive
dependencies, the sitetool can generate a site easily and to date no
one has ever used Doxia itself to generate a site so now seems a
perfect opportunity to decouple the concerns.
Please reconsider, I feel tangling the book and site capabilities in
Doxia make it far harder to manage the change and evolution of Doxia
itself.
Jason.
I have no objection to splitting the site plugin into some maven
site related tools, but I don't think these belong in there.
- Brett
On 19/03/2007, at 5:54 AM, [EMAIL PROTECTED] wrote:
Author: jvanzyl
Date: Sun Mar 18 11:54:20 2007
New Revision: 519667
URL: http://svn.apache.org/viewvc?view=rev&rev=519667
Log:
o site specific modules moved to sitetools
Removed:
maven/doxia/trunk/doxia-decoration-model/
maven/doxia/trunk/doxia-doc-renderer/
maven/doxia/trunk/doxia-site-renderer/
Modified:
maven/doxia/trunk/pom.xml
Modified: maven/doxia/trunk/pom.xml
URL: http://svn.apache.org/viewvc/maven/doxia/trunk/pom.xml?
view=diff&rev=519667&r1=519666&r2=519667
=====================================================================
=========
--- maven/doxia/trunk/pom.xml (original)
+++ maven/doxia/trunk/pom.xml Sun Mar 18 11:54:20 2007
@@ -146,9 +146,6 @@
<modules>
<module>doxia-core</module>
<module>doxia-sink-api</module>
- <module>doxia-site-renderer</module>
- <module>doxia-decoration-model</module>
<module>doxia-modules</module>
- <module>doxia-doc-renderer</module>
</modules>
</project>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
