does this look better? https://svn.apache.org/viewvc/maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/MavenProject.java?r1=627670&r2=627932&pathrev=627932&diff_format=h
On Thu, Feb 14, 2008 at 6:11 PM, Brett Porter <[EMAIL PROTECTED]> wrote: > Ok, well in that case you don't need clone, you just needed to flip > all the get/set's like you did and continue using the copy constructor. > > > > On 15/02/2008, at 12:59 PM, Carlos Sanchez wrote: > > > I dont know why it is there, but it is, line 314 > > > https://svn.apache.org/viewvc/maven/shared/trunk/maven-archiver/src/main/java/org/apache/maven/archiver/MavenArchiver.java?annotate=627672 > > > > emmanuel comment is > > we have to clone the project instance so we can write out the pom with > > the deployment version, without impacting the main project instance... > > > > > > On Thu, Feb 14, 2008 at 5:51 PM, Brett Porter <[EMAIL PROTECTED]> > > wrote: > >> > >> On 15/02/2008, at 12:41 PM, Carlos Sanchez wrote: > >> > >>> The archiver is making a copy of the MavenProject using newProject = > >>> new MavenProject(project) > >>> project is a subclass of MavenProject (EclipseMavenProject) > >>> Instead the archiver should do project.clone() if any > >> > >> I think I was asking the same thing as Jason - I didn't know why the > >> archiver should be creating a new project (and if it was, why it > >> would > >> need to be another instance of the delegate class). > >> > >> > >>> > >>> what @todo are you talking about? > >> > >> I meant in the other code, but it's not relevant since you aren't > >> doing this for lack of update visibility. > >> > >> - Brett > >> > >> > >> > >> -- > >> Brett Porter > >> [EMAIL PROTECTED] > >> http://blogs.exist.com/bporter/ > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [EMAIL PROTECTED] > >> For additional commands, e-mail: [EMAIL PROTECTED] > >> > >> > > > > > > > > -- > > I could give you my word as a Spaniard. > > No good. I've known too many Spaniards. > > -- The Princess Bride > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > -- > Brett Porter > [EMAIL PROTECTED] > http://blogs.exist.com/bporter/ > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > -- I could give you my word as a Spaniard. No good. I've known too many Spaniards. -- The Princess Bride --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
