Le mardi 08 avril 2008, Martin von Gagern a écrit : > +1 for the original proposal, if a newcomer like me is allowed to vote. > > The concept with the property, which can be set with the properties > until the model is updated, and which can be the default expression for > affected plugins, is simply elegant. +1
> I support concerns here that the cost of encoding detection may in many > cases be prohibitively high. Maven runs too slow as it is, imho. You > could of course write an encoding detection plugin which could examine > the code and set the required property accordingly. But enabling that by > default feels bad to me. +1 encoding detection, guessing encoding, is unreliable by nature Why not in a browser, where: - encoding can change on every page - a user looks at the rendered characters, sees a problem easily and fixes the value by simply trying another value and seeing if it is better But embedded in Maven, where encoding is not so volatile and the consequences of a bad guess will be more subtle (for example as the classes compiled will be run and display bad output), I find it a really bad idea. > It should be noted that plugins that generate code to be used by other > plugins should have their output encoding default to the general input > encoding, so that there are no breaks in the chain. it's noted in the proposal, in the list of affected plugins (modello, for example, which generates Java source code) > As Jason writes about consistency, I guess the danger of inconsistent > input handling, as different plugins might be configured to read it > using different charsets, is exactly the kind of inconsistency to be > addressed by this proposal, so I'd expect more consistency after it has > been implemented, not less. +1 until now, few people did care about encoding for non XML sources, and it worked: yes, that's the magic of platform encoding (the drawback is reproducibility) IMHO, the best hint for a user choose his encoding when the default ISO-8859-1 isn't a good valuie for him, is displaying platform encoding (in "mvn -v" output for example): it's easy, reliable, and corresponds to the value he would have got before the change Hervé --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
