2008/4/15, Brett Porter <[EMAIL PROTECTED]>:
> I found a regression in :generate -
>  1) the default (15) is no longer present
This is not intended.

>  2) it no longer prompts for the groupId/etc - it goes straight to using
> some default settings
This is partially intended.
the plugin now provides default for all values and
should ask for confirmation if everithing is correctly set.

>
>  Is that intended?
>
>  I did find a bad license header here:
> archetype-common/src/test/java/org/apache/maven/archetype/test/InternalCatalogFromWiki.java,
> but it's not a blocker.
Do you have a tool for checking the license? or did you check by hand
each files?

>
>  I also noticed that some of the code from Better Builds with Maven is
> reproduced here with the company name changed - I don't see this as a
> problem (it's just sample POMs), but I think it's worth being reminded that
> care should be taken if something is being copied from an external source.
Which code exactly, i don't remember having grabed code from the book.

>
>  I'll leave it up to you whether any are blockers. You have my +1 if you
> choose to go ahead.
I will check tonite for issues 1 and 2.

But we currently have only 2 non binding and 1 binding vote which
is not enough IIRC.

Thanks

Raphaël

>
>  Cheers,
>  Brett
>
>
>  On 11/04/2008, at 6:22 AM, Raphaël Piéroni wrote:
>
>
> > Hi,
> >
> > We solved 20 issues:
> >
> http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11095&styleName=Html&version=14088
> >
> > Staging repo:
> >
> http://people.apache.org/~rafale/archetype-stage-repository/
> >
> > Staging site:
> >
> http://maven.apache.org/plugins/maven-archetype-plugin-2.0-alpha-3
> >
> > Guide to testing staged releases:
> >
> http://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> >
> > Regards,
> >
> > Raphaël
> >
>
>  --
>  Brett Porter
>  [EMAIL PROTECTED]
>  http://blogs.exist.com/bporter/
>
>
>
> ---------------------------------------------------------------------
>  To unsubscribe, e-mail: [EMAIL PROTECTED]
>  For additional commands, e-mail: [EMAIL PROTECTED]
>
>

Reply via email to