On 15/04/2008, at 7:30 PM, Raphaël Piéroni wrote:
I did find a bad license header here:
archetype-common/src/test/java/org/apache/maven/archetype/test/
InternalCatalogFromWiki.java,
but it's not a blocker.
Do you have a tool for checking the license? or did you check by hand
each files?
I found this because I do an SVN diff of the two tags and review the
commits if I haven't done it incrementally.
However, you can also run "mvn rat:check".
I also noticed that some of the code from Better Builds with Maven is
reproduced here with the company name changed - I don't see this as a
problem (it's just sample POMs), but I think it's worth being
reminded that
care should be taken if something is being copied from an external
source.
Which code exactly, i don't remember having grabed code from the book.
All the "proficio" bits. Like I said, I'm not concerned in this
instance - perhaps it even was in the Maven sandbox at one point -
just thought it was worth noting for other instances where copying
might be needed.
Cheers,
Brett
--
Brett Porter
[EMAIL PROTECTED]
http://blogs.exist.com/bporter/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
