Some more comments for the shared model (sorry, going backwards in
time)...
On 18/06/2008, at 2:10 AM, [EMAIL PROTECTED] wrote:
Author: sisbell
Date: Tue Jun 17 11:10:16 2008
New Revision: 668774
URL: http://svn.apache.org/viewvc?rev=668774&view=rev
Log:
General model builder API.
Firstly, same comment about license headers.
+import org.kxml2.io.KXmlParser;
+import org.xmlpull.v1.XmlPullParser;
+import org.xmlpull.v1.XmlPullParserException;
ok, I see where these came in now. I'm concerned about using yet-
another-xml-parser. Personally, I'd prefer the StAX API for all pull
parsing which gives us the choice of the RI, woodstox and kXml3.
+ private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(pom\\.|project\\.|env\\.)?([^}]+)\\}");
This seems to be a backwards step from John's work. How does your work
relate to his?
Added: maven/sandbox/trunk/shared/maven-shared-model/src/main/
resources/pom-1.xml
This looks like a test file, not a main file?
I'll reserve comments on the rest of the impl since I think it still
falls under the same stuff we were originally discussing based on the
document.
Thanks,
Brett
--
Brett Porter
[EMAIL PROTECTED]
http://blogs.exist.com/bporter/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
