Hi Shane,

A few quick comments on this...

Can you make sure there are license headers?

On 18/06/2008, at 6:10 AM, [EMAIL PROTECTED] wrote:

Added: maven/sandbox/trunk/maven/maven-project-builder/maven-project- builder.iml

I think we generally don't check these in.


+        <dependency>
+            <groupId>net.sf.kxml</groupId>
+            <artifactId>kxml2</artifactId>
+            <version>2.2.2</version>
+        </dependency>

I didn't see this used anywhere?

+ private static final Collection<String> uris = Collections.unmodifiableList(Arrays.asList( + ProjectUri.DependencyManagement.Dependencies.Dependency.xUri,
+            ProjectUri.Dependencies.Dependency.xUri,
+ ProjectUri .Profiles.Profile.DependencyManagement.Dependencies.Dependency.xUri,
+            ProjectUri.Profiles.Profile.Dependencies.Dependency.xUri,
+            ProjectUri.Build.PluginManagement.Plugins.Plugin.xUri,
+ ProjectUri .Build.PluginManagement.Plugins.Plugin.Dependencies.Dependency.xUri,
+            ProjectUri.Build.Plugins.Plugin.xUri,
+ ProjectUri.Build.Plugins.Plugin.Dependencies.Dependency.xUri, + ProjectUri .Build .Plugins.Plugin.Dependencies.Dependency.Exclusions.Exclusion.xUri
+    ));

Will the classes that contain these be generated by modello eventually? They're pretty verbose :)

As for the code itself, I'll just wait until you've had time to finish the prototype (still had some open questions from the other mail too).

Cheers,
Brett

--
Brett Porter
[EMAIL PROTECTED]
http://blogs.exist.com/bporter/


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to